tpr/issue167: Fixed explicit connect after connection has disconnected #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 4, 2016 18:28
#167 says that, after a disconnect caused by a network outage, then waiting long enough for the connection to go disconnected state and the channels to be detached, an explicit AblyRealtime.connection.connect() is not immediately actioned. Instead it does not connect until up to a couple of minutes later. It looks like the condition is incorrect in ConnectionManager.connect() to see if a connection attempt is already underway, so the explicit connect does not do anything. Instead it waits until the next time it would have attempted a reconnect anyway. Fixed. Also fixed so that the connect happens even if there is a connection thread already started.
This tests the fix for #167
|
Thanks, LGTM, should I merge |
|
Yes please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a test for the regression.