Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/fix Travis tests #372

Merged
merged 15 commits into from
Mar 16, 2018
Merged

Add/fix Travis tests #372

merged 15 commits into from
Mar 16, 2018

Conversation

funkyboy
Copy link
Contributor

@funkyboy funkyboy commented Mar 13, 2018

Note to self: you cannot run x86 images on Travis.
Related issue

  • Make tests running on android-22, java8 and openjdk
  • Add Slack and email notifications

Fix #364

@funkyboy funkyboy force-pushed the fix-travis-tests branch 3 times, most recently from e4311ba to 59d2731 Compare March 15, 2018 08:50
@funkyboy
Copy link
Contributor Author

funkyboy commented Mar 15, 2018

@paddybyers Stuck here: https://travis-ci.org/ably/ably-java/jobs/353722078
Fixing is becoming impractical, as in waiting 15m to see the results of a change.

Will follow these instructions and work locally with docker to check what's the problem.

@@ -0,0 +1 @@
org.gradle.jvmargs=-Xmx1536M
Copy link
Contributor Author

@funkyboy funkyboy Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to avoid To run dex in process, the Gradle daemon needs a larger heap. message in Travis.

@funkyboy funkyboy force-pushed the fix-travis-tests branch 3 times, most recently from 43f813a to 1b0f061 Compare March 15, 2018 17:54
@funkyboy
Copy link
Contributor Author

@paddybyers status so far:

@paddybyers
Copy link
Member

the gradlew java:* command somehow calls stuff that is related to the android “context”. That leads to https://travis-ci.org/ably/ably-java/jobs/353969106#L2000

Are you sure that's the correct link? I see a bytecode version error there

@funkyboy
Copy link
Contributor Author

@paddybyers Yes, that's the link I meant. Also this (same error).

I think that when running java:* tests the file /home/travis/build/ably/ably-java/android/build.gradle shouldn't be read and could even not exist.

@paddybyers
Copy link
Member

I think that when running java:* tests the file /home/travis/build/ably/ably-java/android/build.gradle shouldn't be read and could even not exist.

It might not exist but, since it does, it will be processed. The top-level build.gradle is the thing that's being processed to determine the tasks for the project (which include java-specific tasks). When you say gradle java:xxx then you're asking for that task in that subproject, but it will still process the whole project.

@funkyboy funkyboy force-pushed the fix-travis-tests branch 4 times, most recently from f2c3f18 to 77021b4 Compare March 16, 2018 13:16
@funkyboy funkyboy requested a review from paddybyers March 16, 2018 13:17
@funkyboy funkyboy changed the title WIP: Add/fix Travis tests Add/fix Travis tests Mar 16, 2018
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added one question.

TBH I think we could collapse all of this into a single commit because there's a bit of back-and-forth in here.

@@ -0,0 +1 @@
./gradlew connectedAndroidTest --info
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the --info ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

@funkyboy funkyboy merged commit 8d4b37d into develop Mar 16, 2018
@funkyboy funkyboy deleted the fix-travis-tests branch March 16, 2018 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants