Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Travis timeout on Android tests #391

Merged
merged 1 commit into from
May 11, 2018
Merged

Prevent Travis timeout on Android tests #391

merged 1 commit into from
May 11, 2018

Conversation

funkyboy
Copy link
Contributor

@funkyboy funkyboy commented May 10, 2018 •
edited
Loading

Sometimes Travis builds for android fail due to a timeout.
Example here
This happens because:

  • there's no test failure for > 10 minutes
  • Travis detects that there's no output for longer than default timeout (10 minutes)
  • Travis terminates the build

This PR makes android tests more verbose to avoid the timeout.

@funkyboy funkyboy force-pushed the fix-travis-timeout-on-android-tests branch 5 times, most recently from ec6a95b to 2f3c8b1 Compare May 10, 2018 20:16
paddybyers
paddybyers approved these changes May 10, 2018
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@funkyboy funkyboy force-pushed the fix-travis-timeout-on-android-tests branch from 2f3c8b1 to 01d917f Compare May 10, 2018 20:47
@funkyboy funkyboy changed the title Use greater Travis timeout Prevent Travis timeout on Android tests May 11, 2018
@funkyboy funkyboy force-pushed the fix-travis-timeout-on-android-tests branch from 01d917f to 44591f1 Compare May 11, 2018 07:35
@funkyboy funkyboy merged commit 66b2a33 into develop May 11, 2018
@funkyboy funkyboy deleted the fix-travis-timeout-on-android-tests branch May 11, 2018 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddybyers paddybyers paddybyers approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@funkyboy @paddybyers