Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log error message to get clear understanding of exception #632

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Log error message to get clear understanding of exception #632

merged 2 commits into from
Jan 21, 2021

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Nov 21, 2020

@sacOO7 sacOO7 requested a review from paddybyers November 24, 2020 12:40
paddybyers
paddybyers approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@sacOO7 sacOO7 requested a review from QuintinWillison January 1, 2021 12:21
@QuintinWillison QuintinWillison merged commit faa0ed7 into main Jan 21, 2021
@QuintinWillison QuintinWillison deleted the fix/606-handshake-failure branch January 21, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddybyers paddybyers paddybyers approved these changes

@QuintinWillison QuintinWillison Awaiting requested review from QuintinWillison

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sacOO7 @paddybyers @QuintinWillison