Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getRandomMessageId #656

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Fix getRandomMessageId #656

merged 1 commit into from
Mar 3, 2021

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Mar 2, 2021 •
edited
Loading

@sacOO7 sacOO7 requested a review from QuintinWillison March 2, 2021 17:21
@QuintinWillison
Copy link
Contributor

@paddybyers given idempotent message publishing was added by you in #435, I'm going to add you as a reviewer here. Thanks.

paddybyers
paddybyers approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@QuintinWillison QuintinWillison merged commit a6f0431 into main Mar 3, 2021
@QuintinWillison QuintinWillison deleted the fix/654-random-message-id branch March 3, 2021 13:17
@vzhikserg vzhikserg added the bug Something isn't working. It's clear that this does need to be fixed. label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintinWillison QuintinWillison QuintinWillison approved these changes

@paddybyers paddybyers paddybyers approved these changes

Assignees

@sacOO7 sacOO7

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crypto.getRandomMessageId isn't working as intended
4 participants
@sacOO7 @QuintinWillison @paddybyers @vzhikserg