Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum API Level supported for Android is 19 (KitKat, v.4.4) #804

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

QuintinWillison
Copy link
Contributor

@QuintinWillison QuintinWillison commented Jun 20, 2022

We were declaring incorrectly.

I propose releasing this with our next version 1.2 patch and, as such, am treating this change as foundational to my fix for #801.

For example, AutoCloseable.
Also, our targetSdkVersion did not match our compileSdkVersion.
@QuintinWillison QuintinWillison added the bug Something isn't working. It's clear that this does need to be fixed. label Jun 20, 2022
@QuintinWillison QuintinWillison self-assigned this Jun 20, 2022
@QuintinWillison QuintinWillison marked this pull request as ready for review June 20, 2022 15:27
Copy link
Contributor

@ikbalkaya ikbalkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the possibility of some of (if there are any) of our users missing new SDK versions, looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Development

Successfully merging this pull request may close these issues.

4 participants