Feature/no connection serial recovery key #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/980/features
github-actions
bot
temporarily deployed
to
staging/pull/980/javadoc
…n-serial-recovery-key
github-actions
bot
temporarily deployed
to
staging/pull/980/features
github-actions
bot
temporarily deployed
to
staging/pull/980/javadoc
github-actions
bot
temporarily deployed
to
staging/pull/980/features
github-actions
bot
temporarily deployed
to
staging/pull/980/javadoc
sacOO7
force-pushed
the
feature/no-connection-serial-recovery-key
branch
from
229617e to
1509938
Compare
github-actions
bot
temporarily deployed
to
staging/pull/980/features
github-actions
bot
temporarily deployed
to
staging/pull/980/javadoc
github-actions
bot
temporarily deployed
to
staging/pull/980/features
github-actions
bot
temporarily deployed
to
staging/pull/980/javadoc
github-actions
bot
temporarily deployed
to
staging/pull/980/features
github-actions
bot
temporarily deployed
to
staging/pull/980/javadoc
github-actions
bot
temporarily deployed
to
staging/pull/980/features
github-actions
bot
temporarily deployed
to
staging/pull/980/javadoc
github-actions
bot
temporarily deployed
to
staging/pull/980/javadoc
github-actions
bot
temporarily deployed
to
staging/pull/980/features
github-actions
bot
temporarily deployed
to
staging/pull/980/javadoc
github-actions
bot
temporarily deployed
to
staging/pull/980/features
github-actions
bot
temporarily deployed
to
staging/pull/980/javadoc
sacOO7
force-pushed
the
feature/no-connection-serial
branch
from
6461967 to
72992c9
Compare
github-actions
bot
temporarily deployed
to
staging/pull/980/features
github-actions
bot
temporarily deployed
to
staging/pull/980/javadoc
ttypic
reviewed
Nov 30, 2023
| public RecoveryKeyContext(String connectionKey, long msgSerial, Map<String, String> channelSerials) { | ||
| this.connectionKey = connectionKey; | ||
| this.msgSerial = msgSerial; | ||
| this.channelSerials.putAll(channelSerials); |
There was a problem hiding this comment.
Out of curiosity, why do we copy channelSerials?
There was a problem hiding this comment.
General principal of immutability. We have marked channelSerials field as immutable, so it shouldn't get influenced by
changes in external channelserials and should only capture snapshot of serials at the time of creating the instance.
There was a problem hiding this comment.
Got you! (one more point to rewrite lib in Kotlin) I personally prefer using analog of guava's ImmutableMap which just wraps around existing Map rather than make Map's copy. But it this particular code probably no harm to copy
github-actions
bot
temporarily deployed
to
staging/pull/980/features
github-actions
bot
temporarily deployed
to
staging/pull/980/features
ttypic
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #974
Related #846
Related #976