Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove detach hack in useChannel #1796

Merged
merged 1 commit into from
Jun 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/platform/react-hooks/src/hooks/useChannel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,4 @@ async function handleChannelMount(channel: Ably.RealtimeChannel, ...subscribeArg

async function handleChannelUnmount(channel: Ably.RealtimeChannel, ...subscribeArgs: SubscribeArgs) {
await (channel.unsubscribe as any)(...subscribeArgs);

setTimeout(async () => {
// React is very mount/unmount happy, so if we just detatch the channel
// it's quite likely it will be reattached again by a subsequent handleChannelMount calls.
// To solve this, we set a timer, and if all the listeners have been removed, we know that the component
// has been removed for good and we can detatch the channel.
if (channel.listeners.length === 0) {
await channel.detach();
}
}, 2500);
}
Loading