Add support for jittered initial scale #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theanti9
reviewed
Nov 21, 2023
| @@ -134,7 +134,8 @@ pub fn particle_spawner( | |||
| .z_value_override | |||
| .as_ref() | |||
| .map_or(0.0, |jittered_value| jittered_value.get_value(&mut rng)); | |||
| let particle_scale = particle_system.scale.at_lifetime_pct(0.0); | |||
| let initial_scale = particle_system.initial_scale.get_value(&mut rng); | |||
| let particle_scale = initial_scale * particle_system.scale.at_lifetime_pct(0.0); | |||
There was a problem hiding this comment.
Hmm. So this changes scale from an absolute scale to a relative, as we're always multiplying the scale value by the initial_scale. You commented to this effect on initial_scale, but maybe we should also call this out on the doc for scale, that it is relative to initial_scale.
johanhelsing
force-pushed
the
jittered-scale
branch
from
7315f72 to
cab41c1
Compare
theanti9
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors implementation of
initial_rotationandinitial_speed