-
-
Notifications
You must be signed in to change notification settings - Fork 595
Regression: GPL false positive license detections with v32.3.0 #4005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
tagging @meretp @leslielazzarino |
@alexzurbonsen thanks a lot for your report! At first glance this does seem like a side effect of modifying the false positive detection heuristics at (we report possible false positives as license clues) f9863e6 which caused the regression. This would be a nice example to add and further refine this part. |
@AyanSinhaMahapatra thanks for the swift reply! Not sure I got it right: Are you looking into it or should I do something? |
Hey @AyanSinhaMahapatra, I think I found the problem and opened #4009, see above. |
same issue in #3270 |
Description
With v32.3.0 we are observing false positive GPL license detections that did not occurr with v32.2.1.
The examples we have found are caused by matches with the
gpl_bare_word_only.RULE
. In v32.2.1 these detections were categorized aslicense_clues
.An example:
https://github.com/steinwurf/boost/blob/ade3189e2c03fd975dbfa667a4f49e98a49d2fdf/boost/assign/ptr_list_of.hpp#L196
For example the lines 196-198
yield three GPL detections with v32.3.0. (There are other similar snippets in the file.)
How To Reproduce
Run once for v32.3.0 and once for v32.2.1
See attached scancode files for my results.
System configuration
scancode_32.2.1.json
scancode_32.3.0.json
The text was updated successfully, but these errors were encountered: