in gql default to subscription instead of query

[pie6k]

All gql hooks default to subscribtion with .query being optional

[linear]

ACA-439 with gql default to subscription instead of query

[heikir]

Looks good, but don't you think having subscriptions as the default is a bit misleading?

[pie6k]

my thinking was we want the app to work in realtime and I cought myself being confused a few times only because I forgot to add .subscribtion and something did not refresh nicely.

So I imagine in general we want it everywhere to see changes other people are doing in real time etc. Query will probably be rather unusual use case

[omarduarte]

I was a bit worried about our connections, but it seems like Hasura can handle this
https://github.com/hasura/graphql-engine/blob/master/architecture/live-queries.md

[omarduarte]

Althou, take into account that we'll get into pitfalls like this:
apollographql/apollo-client#5267

[pie6k]

@omarduarte about the issue you posted. It'll not happen as our useSubscribtion hooks actually uses query hook as well to address exactly this issue.

    const [queryData] = useAsQuery(variables);
    const subscriptionResult = useRawSubscription(getSubscriptionQuery(), {
      ...options,
      variables: variables as Variables,
    });

    const data = useLatest(subscriptionResult.data, queryData);

👆 we get both query and subscribtion and useLatest. In case of optimistic update, only query will update and thus it'll become 'latest' resulting in correct hook result.