From 27f2754a98a48503157007fbdea359c039b6e5e2 Mon Sep 17 00:00:00 2001 From: breandan Date: Wed, 14 Nov 2018 03:41:39 -0500 Subject: [PATCH] add TODOs for #139, #254, #233, #228, #200, #172, #215 --- src/main/kotlin/org/acejump/config/AceConfig.kt | 2 ++ src/main/kotlin/org/acejump/config/AceSettings.kt | 1 + src/main/kotlin/org/acejump/label/Pattern.kt | 1 + src/main/kotlin/org/acejump/view/Canvas.kt | 1 + src/main/kotlin/org/acejump/view/Marker.kt | 3 +++ src/main/kotlin/org/acejump/view/Model.kt | 2 +- src/test/kotlin/AceTest.kt | 1 + 7 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/main/kotlin/org/acejump/config/AceConfig.kt b/src/main/kotlin/org/acejump/config/AceConfig.kt index af2eb2b8..f4e9b8ee 100644 --- a/src/main/kotlin/org/acejump/config/AceConfig.kt +++ b/src/main/kotlin/org/acejump/config/AceConfig.kt @@ -8,6 +8,8 @@ import com.intellij.openapi.options.Configurable /* Persists the state of the AceJump IDE settings across IDE restarts. * https://www.jetbrains.org/intellij/sdk/docs/basics/persisting_state_of_components.html + * + * TODO: https://github.com/acejump/AceJump/issues/254 */ @State(name = "AceConfig", storages = [(Storage("AceJump.xml"))]) diff --git a/src/main/kotlin/org/acejump/config/AceSettings.kt b/src/main/kotlin/org/acejump/config/AceSettings.kt index 3e0a3c7c..76de923e 100644 --- a/src/main/kotlin/org/acejump/config/AceSettings.kt +++ b/src/main/kotlin/org/acejump/config/AceSettings.kt @@ -5,6 +5,7 @@ import java.awt.Color import java.awt.Color.* import kotlin.reflect.KProperty +// TODO: https://github.com/acejump/AceJump/issues/215 data class AceSettings(var layout: KeyLayout = KeyLayout.QWERTY, var allowedChars: String = layout.allChars(), // These must be primitives in order to be serializable diff --git a/src/main/kotlin/org/acejump/label/Pattern.kt b/src/main/kotlin/org/acejump/label/Pattern.kt index ce7e1ae5..88252e86 100644 --- a/src/main/kotlin/org/acejump/label/Pattern.kt +++ b/src/main/kotlin/org/acejump/label/Pattern.kt @@ -57,6 +57,7 @@ enum class Pattern(val string: String) { get() = when (this) { QWERTY -> "fjghdkslavncmbxzrutyeiwoqp5849673210" // TODO: Prioritize keys by ease of reach for other keyboards + // TODO: https://github.com/acejump/AceJump/issues/172 WORKMN -> "fjghdkslavncmbxzrutyeiwoqp5849673210" COLEMK -> "fjghdkslavncmbxzrutyeiwoqp5849673210" DVORAK -> "fjghdkslavncmbxzrutyeiwoqp5849673210" diff --git a/src/main/kotlin/org/acejump/view/Canvas.kt b/src/main/kotlin/org/acejump/view/Canvas.kt index 0f85e961..6294d197 100755 --- a/src/main/kotlin/org/acejump/view/Canvas.kt +++ b/src/main/kotlin/org/acejump/view/Canvas.kt @@ -45,6 +45,7 @@ object Canvas : JComponent(), Resettable { private fun Editor.storeBounds() { viewBounds = getView() + // TODO: Fix reference, cf. https://github.com/acejump/AceJump/issues/200 this::offsetToLogicalPosition.let { logger.info("View bounds: $viewBounds (lines " + "${it(viewBounds.first).line}..${it(viewBounds.last).line})") diff --git a/src/main/kotlin/org/acejump/view/Marker.kt b/src/main/kotlin/org/acejump/view/Marker.kt index 8bc2f22c..58dbd70e 100644 --- a/src/main/kotlin/org/acejump/view/Marker.kt +++ b/src/main/kotlin/org/acejump/view/Marker.kt @@ -132,6 +132,9 @@ class Marker : CustomHighlighterRenderer { drawString(tag!!.toUpperCase(), tagPosition!!.x, tagPosition.y + fontHeight) } + // TODO: Fix tag alignment and visibility issues + // https://github.com/acejump/AceJump/issues/233 + // https://github.com/acejump/AceJump/issues/228 private fun String.alignTag(canvas: Canvas): Point { val x = tagPoint.x + fontWidth // val top = Point(x - fontWidth, y - fontHeight) diff --git a/src/main/kotlin/org/acejump/view/Model.kt b/src/main/kotlin/org/acejump/view/Model.kt index 489963b6..152b6965 100644 --- a/src/main/kotlin/org/acejump/view/Model.kt +++ b/src/main/kotlin/org/acejump/view/Model.kt @@ -16,7 +16,7 @@ import java.awt.Font.BOLD /** * Data holder for all settings and IDE components needed by AceJump. * - * TODO: Integrate this class with AceSettings. + * TODO: Integrate this class with [org.acejump.config.AceSettings] */ object Model { diff --git a/src/test/kotlin/AceTest.kt b/src/test/kotlin/AceTest.kt index 130e5d17..4f04a06f 100644 --- a/src/test/kotlin/AceTest.kt +++ b/src/test/kotlin/AceTest.kt @@ -6,6 +6,7 @@ import com.intellij.testFramework.EditorActionTestCase class AceTest : EditorActionTestCase() { override fun getActionId() = "AceAction" + // TODO: Improve test coverage, https://github.com/acejump/AceJump/issues/139 fun testSomething() { assert(true) }