Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grenades - Make flashbang reaction more authentic #6034

Merged
merged 3 commits into from
Feb 22, 2020
Merged

Conversation

BaerMitUmlaut
Copy link
Member

When merged this pull request will:

  • Make players flinch and AI try to look away as a reaction to a flashbang explosion - previously both players and AI turned 180° away from the explosion, making it very confusing and weird for players to be suddenly turned around
  • Improve effect strength calculation for AI using eye position instead of ground position

@BaerMitUmlaut BaerMitUmlaut added the kind/enhancement Release Notes: **IMPROVED:** label Jan 7, 2018
@bux
Copy link
Member

bux commented Jan 7, 2018

#69 (comment)

A "proper" flashbang effect is very important to me.

How does this PR change the effectiveness of flash bangs?

very confusing and weird for players to be suddenly turned around

By Design

@BaerMitUmlaut
Copy link
Member Author

No change in effectiveness imo, because you're still blinded and your aim will still be off. The 180° rotation is just unintuitive, because you can't give feedback to the player that he did that until the blinding effect goes away. Unless you have a heavy concussion you should still somewhat know what movement you just did, and that is not the case with a full rotation.

Effects with this PR are:

  • AI turns away between 40° and 135° from the explosion.
  • Players get an offset added to their aim direction, which is randomized but also has a minimum, so you will always flinch somewhat. The maximum effect strength now will be turning away between 45° and 90°. I would add a vertical offset to the aim, but I don't think that's possible.

@kymckay
Copy link
Member

kymckay commented Jan 7, 2018

Yeah I don't believe we'd get a better implementation without being able to fake mouse input (setMousePosition does nothing when used during gameplay right?).

I like this aproach 👍 Without being able to give the feedback that would be given by equilibrioception in real life (i.e. being able to tell they'd turned around even though they can't see), I think it's bad design to turn players around completely.

@bux
Copy link
Member

bux commented Jan 10, 2018

I've tried it and I like the randomization. I'd like to see a higher minimum offset of maybe 60°. For AI this is fine for me. Players though shouldn't have a reduced penalty compared to AI.

@BaerMitUmlaut
Copy link
Member Author

The idea of the higher offset for AI is that they try to turn away from the flashbang. The player might do that intuitively, the AI won't, thus we force them.

@jonpas jonpas added this to the 3.13.0 milestone Jan 22, 2018
bux
bux previously requested changes Jan 23, 2018
Copy link
Member

@bux bux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more player flinch plox

@jonpas
Copy link
Member

jonpas commented Feb 18, 2018

@BaerMitUmlaut @bux ?

Increased min player flinch for flashbangs to 60 decreases, slightly increased the max flinch to go along with this as well.
@thojkooi
Copy link
Contributor

thojkooi commented Jul 8, 2018

@bux, did the change. Also increased max flinch a little bit.

@PabstMirror PabstMirror changed the title Make flashbang reaction more authentic Grenades - Make flashbang reaction more authentic Dec 17, 2019
@PabstMirror PabstMirror requested a review from bux December 17, 2019 16:07
@jonpas jonpas modified the milestones: 3.13.0, 3.13.1 Dec 18, 2019
@CG-Delta
Copy link

CG-Delta commented Feb 12, 2020

Consider doing the same to lethal hand grenades. If you want to keep it realistic (see thread title) and you make them do damage, pain or strong arcade-like blindness, consider getting a source first where this is true, which it is not for the 6-bang here (http://www.angelopodesta.com/documenti/07_d380e0111_6bang.pdf).

#69 (comment)

@commy2
Copy link
Contributor

commy2 commented Feb 13, 2020

Are you considering doing that or is this a low key request?

@CG-Delta
Copy link

CG-Delta commented Feb 13, 2020

I have no such ability no. It's a suggestion/request/correction. It appears like a smaller task to port the same effect already made onto other grenades. But what do I know. All that seems simple at first gets complicated in some way.

@commy2
Copy link
Contributor

commy2 commented Feb 13, 2020

Okay. Feel free to repost your comment. But it really did not belong on a 5 year old closed issue.

@CG-Delta
Copy link

Better there than here, I thought.

@commy2
Copy link
Contributor

commy2 commented Feb 13, 2020

Nope.

Co-Authored-By: PabstMirror <pabstmirror@gmail.com>
@jonpas jonpas dismissed bux’s stale review February 22, 2020 20:36

No further comment.

@jonpas jonpas merged commit 3bc727f into master Feb 22, 2020
@jonpas jonpas deleted the flashbang-reaction branch February 22, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants