-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nametags - Add Nation Ranks #7094
Conversation
Adds German, British, Spanish, French ranks. Also adds postInit code that loops through all factions and checks if ranks have been set there in there for easy, permanent customistability.
https://git.koffeinflummi.de/bwmod-team/bwa3-public/blob/master/bwa3_common/XEH_postInit.sqf#L8-21
|
Changes faction config entry to array with macros and changes the postInit code to commy2's improved version.
Co-Authored-By: Dedmen Miller <dedmen@users.noreply.github.com>
Also removed white space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two missing newlines @eof and this can be merged.
Co-Authored-By: commy2 <commy-2@gmx.de>
Co-Authored-By: commy2 <commy-2@gmx.de>
@@ -45,3 +45,12 @@ GVAR(showNamesTime) = -10; | |||
|
|||
// civilians don't use military ranks | |||
["CIV_F", ["","","","","","",""]] call FUNC(setFactionRankIcons); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a way to disable, don't think it needs a setting.
We tend to use base vanilla units and just change the uniforms, so this doesn't really make sense for us, and would probably just be confusing
Does CSAT = russian and greek = german make sense?
if (missionNamespace getVariable [QGVAR(skipCustomRankIcons), false]) exitWith {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't you just overwrite the civs with whatever icons you want instead by using the same function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
civs are fine, I just want to skip the for loop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Russian ranks and Iranian ranks are somewhat similar, the Chinese stand out somewhat in that they used downward point chevrons mostly. I don't know exactly how to reconcile in-game lore and geopolitics with the ranks, but if NATO gets all the American ranks, then maybe CSAT should get the Chinese ones? It's a little problematic that these nationally diverse alliances (CSAT/NATO) are one faction in game.
As for the AAF getting the German ranks; the AAF is mostly NATO-built force, and they have a bunch of equipment from all over NATO, so maybe they should just get NATO ranks.
When it comes to the new ranks, I'm not fussed as to who gets what. Just tell me what you need. If need be I'll happily add in more ranks for different nations and/or create some separate ranks for the AAF, FIA. The incoming Livonians should probably use the NATO ranks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make some ranks for the NVA. :)
They'd be used in GM, and they are simple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a getVar setting for this,
along with a check to make sure it doesn't overwrite existing entries
e.g. mission init.sq called setFactionRankIcons first
Can't merge, because:
|
Commy, you should read #general on Slack more often. ;) |
When merged this pull request will:
This addition would allow mod makers to set custom ranks on their faction, so that British units are walking around with British rank insignia, Spanish with Spanish rank insignia, etc.
Letting mod makers define their own path allows them to add in custom rank insignia for countries that aren't defined yet.