Spanish translations #7235
Merged
Spanish translations #7235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some more translations into spanish for ai,ui,vehicles, weapons and zeus
Turksih Translation for AI Aircraft Main Map and Medical Feedback started
|
Can you please properly fill out the template PR ? |
|
Added description |
|
How come you speak Turkish and Spanish? |
commy2
approved these changes
Oct 10, 2019
|
Haha my buddy and best man is Turkish and my wife used to life in Spain :) |
TheMagnetar
requested changes
Oct 10, 2019
TheMagnetar
previously requested changes
Oct 10, 2019
654wak654
previously requested changes
Oct 10, 2019
There was a problem hiding this comment.
I don't like the Turkish translations. They're good word by word translations but some of them don't convey the same meaning as their English counterpart.
For example the word "On" is translated as "üzerinde" but in this context it should've been "Açık" (Also why lower case?).
Overall it feels like some really low effort translations, and since there aren't many of them I think we could do without them.
Co-Authored-By: Ferran Obon <themagnetar@users.noreply.github.com>
PabstMirror
dismissed stale reviews from 654wak654 and TheMagnetar
dropped turk translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Add Spanish translation for
Dogtags
UI
AI
Vehicles
Weapons
Zeus
Turkish translation for
UI (incomplete)
AI (incomplete)