Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handheld maglite ML300L flashlight, clean up flashlight addon #7277

Merged
merged 26 commits into from
Dec 3, 2019

Conversation

bux
Copy link
Member

@bux bux commented Nov 21, 2019

When merged this pull request will:

  • Add a maglite flashlight model

    • Will use pistol slot
  • Cleanup of flashlight addon folder

  • Holding animation

  • Different Light modes?! 2 intensity levels, 1 strobe level

  • Remove weapon attachment options

  • Allow to be used as map light

@bux bux added the kind/enhancement Release Notes: **IMPROVED:** label Nov 21, 2019
…er fit holding animation, add model.cfg required for binarizing rtm
@bux bux changed the title Add handheld maglite ML300L flashlight, clean up flashlight addon WIP: Add handheld maglite ML300L flashlight, clean up flashlight addon Nov 24, 2019
@commy2
Copy link
Contributor

commy2 commented Nov 30, 2019

Done. Only issue I found is Warnings in z\ace\addons\flashlights\data\maglite_ml300l.p3d:shadow(1000), but idk how to fix that.

@bux
Copy link
Member Author

bux commented Dec 2, 2019

Left clicking (shooting) throws following message in a popup and in rpt
16:53:06 Warning Message: Size: 'bin\config.bin/CfgRecoils/recoil_default/' not an array

@commy2 commy2 removed the status/WIP label Dec 3, 2019
@commy2 commy2 changed the title WIP: Add handheld maglite ML300L flashlight, clean up flashlight addon Add handheld maglite ML300L flashlight, clean up flashlight addon Dec 3, 2019
@commy2 commy2 added this to the 3.13.0 milestone Dec 3, 2019
@bux
Copy link
Member Author

bux commented Dec 3, 2019

Should we keep the binarized rtm or the unbinarized one?

@commy2
Copy link
Contributor

commy2 commented Dec 3, 2019

I'd say both. One to keep this component functional in dev builds, one to make further changes to the animation file possible. Ideally the build would handle animations and binarize them, but this is out of scope for this PR, and a minor issue overall due to the low number of RTM files in ACE.

@bux
Copy link
Member Author

bux commented Dec 3, 2019

the unbinarized rtm can't be used to edit the animation afaik. There's nothing in Alwarran's tool for blender to "import" an rtm. Which - to me - means that an rtm has to be exported from the blender rig source file each time one wants to change the animation

@commy2
Copy link
Contributor

commy2 commented Dec 3, 2019

Should probably get the project files then and put them into the component or into a dev folder.

@bux
Copy link
Member Author

bux commented Dec 3, 2019

Done.

@commy2
Copy link
Contributor

commy2 commented Dec 3, 2019

Merge?

@commy2 commy2 merged commit 76f0d76 into master Dec 3, 2019
@commy2 commy2 deleted the maglite branch December 3, 2019 18:13
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.13.0-temp1 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants