-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medical - Add ability for unit specific damage threshold #7455
Conversation
WDYT about adding eden attribute for this? |
@veteran29 question is how. It would not make sense to do a 1:1 threshold translation. |
Added threshold slider to units |
attribute setters are code. Can check for == default and just not set the var |
I've done it now a bit differently, as the slider is more precise than what is shown on the number selector, anything below 0.1, which shows as 0 on the selector, will be seen as "use cba settings threshold value". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment
2b22428
to
bce9047
Compare
Can the label "status/WIP" be removed? This was done some time ago. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
When merged this pull request will:
The new macro differentiates between AI and player.
The variable name for this is currently
ace_medical_unitDamageThreshold
. This is the same name the old medical system used. However the value was an array of 3 values in the old system. Now it is just a number.So, it is debatable which name for the variable should be used.