CSW - Minor fixes for CSW + RHS Compats #7497

Whigital · 2020-01-29T22:45:44Z

When merged this pull request will:

ace_csw:

Add Mk6 Mortar icon.

ace_compat_rhs_usf3 / ace_compat_rhs_afrf3/ ace_compat_rhs_gref3:

Add WeaponSlotsInfo to get rid of error picture error when opening inventory.
Use rhs_SPG9_INS instead of rhsgref_ins_SPG9 for ace_compat_rhs_afrf3_spg9_carry.
Add ACE_CSW inheritance on ace_compat_rhs_afrf3_spg9m_carry.

commy2 · 2020-01-29T23:02:44Z

Why would static weapons appear in the arsenal?

optionals/compat_rhs_afrf3/CfgWeapons.hpp

commy2 · 2020-01-29T23:05:43Z

RHS compat icons extracted from RHS. If you believe there might be an licensing issue, we can swap them for the generic icons in csw.

There is no reason to do this. Just use the external filepath.

Tbh, for legal reasons, these commits should be rebased.

Whigital · 2020-01-29T23:24:56Z

Why would static weapons appear in the arsenal?

Isn't the whole point of CSW, to have a crew that serves a weapon platform ?

What is the point of the weapon and tripod bags if you can't equip them from the arsenal. Maybe I've completely misunderstood the purpose of the module.

There is no reason to do this. Just use the external filepath.

When equipped, you get an error when looking in the inventory (ex. Warning Message: Picture \rhsusf\addons\rhsusf_heavyweapons\data\ico\rhs_m252_x_ca.paa not found). I'm suspecting that Arma tries to find a higher/lower res version of the picture to display as icon in the inventory. Removing the _co suffix seems to disable this behavior, so i copied and renamed the .paa.

Tbh, for legal reasons, these commits should be rebased.

I'll point them to the generic icons in csw if thats ok ?

commy2 · 2020-01-29T23:27:18Z

I'll point them to the generic icons in csw if thats ok ?

No, use the RHS paths. If they changed them, adjust the paths. Obviously you have to start RHS to start these components.

commy2 · 2020-01-29T23:30:44Z

addons/csw/CfgWeapons.hpp

@@ -148,6 +145,9 @@ class CfgWeapons {
        model = QPATHTOEF(apl,ACE_CSW_Bag.p3d);
        modes[] = {};
        picture = QPATHTOF(UI\StaticAT_Icon.paa);
+        magazines[] = {
+            "Titan_AT"


This does make them be able to load the magazines, doesn't it?

Yes, if you have it (the weapon bag) equipped, you can drag a mag to it, but nothing happens.

That's terrible.

For a Titan/Spike AT, i guess its pretty obvious what kind of mag you need for it, but adding compatible mags to the array is the only way to know what ammo you need for the weapon. Otherwise you have to scroll through the "All Magazines" list and pray you pick up the right one.

We can remove them, but the convenience of having the compatible mags listed under Magazines maybe outweighs the fact you can "placebo load" the weapon with them ?

Maybe consider adding custom properties for magwells and magazine classes. Content of these properties could be read by ACE Arsenal and shown on the magazine list.

Whigital · 2020-01-29T23:33:17Z

No, use the RHS paths. If they changed them, adjust the paths. Obviously you have to start RHS to start these components.

I did, of course. With the RHS paths, the icon/picture shows up in the arsenal ok, but when you exit and look in your inventory, the error pops up and the launcher slot is blank.

commy2 · 2020-01-29T23:37:18Z

Does the picture error happen in the release version of ACE?

commy2 · 2020-01-29T23:44:44Z

I don't understand what type = 4; does here. That value should be inherited from LauncherCore.
Rule of thumb: type or simulation in public class -> you dun goofed or pulled something genius (unlikely)

Whigital · 2020-01-29T23:47:52Z

Does the picture error happen in the release version of ACE?

Yepp, just tested with SW versions ACE + USAF/AFRF/GREF + compats:

Equipped a ace_compat_rhs_usf3_mk19_carry in the arsenal, exit and open inventory.

0:40:43 Warning Message: Picture \rhsusf\addons\rhsusf_heavyweapons\data\ico\rhs_mk19_tripod_x_ca.paa not found

https://github.com/acemod/ACE3/blob/master/optionals/compat_rhs_usf3/CfgWeapons.hpp#L546

Whigital · 2020-01-29T23:54:41Z

I don't understand what type = 4; does here. That value should be inherited from LauncherCore.
Rule of thumb: type in public class -> you dun goofed or pulled something genius (unlikely)

Correct, did a boo boo there. Looked at the wrong classes. The actual static weapons that has a corresponding vehicle for them have 65535. Will remove those declarations.

Whigital · 2020-01-30T02:09:47Z

Most of the requested changes done now. Added a MuzzleSlot placeholder to make the engine use the supplied image based on this info -> https://community.bistudio.com/wiki/Arma_3_Weapon_Config_Guidelines#Inventory_icons_overlay_method

Image now shows in player inventory without any errors ....

veteran29 · 2020-01-30T02:34:04Z

Why would static weapons appear in the arsenal?

Without ACE CSW static weapons are available as backpack variants, I see no reason to not have launcher slot variants in it too. Otherwise to get launcher slot variants you would need to assemble backpack versions and disassemble them via CSW to get them.

Ideally you would have backpack versions in arsenal when CSW is disabled and opposite if enabled.

dedmen · 2020-01-30T08:47:31Z

RHS compat icons extracted from RHS.

RHS will rip your ass up and potentially cause issues for us if you do that. So no no no no no.

Tbh, for legal reasons, these commits should be rebased.

yes. Definitely. Please do that, right now the RHS icons are still in history. Should be fine if we just squash&merge at the end though, if author doesn't want to fix it.

Whigital · 2020-01-30T17:29:59Z

Would you like me to remove the mag. defs. and just keep the other fixes, or just rebase as is ?

PabstMirror · 2020-01-30T17:31:10Z

Tag @TheCandianVendingMachine

TheCandianVendingMachine · 2020-01-30T19:29:53Z

@Whigital I would say remove the mag defs for right now. I'll take a look at ACE Arsenal to try and find a way to have compatible magazines show up if you have the launcher equipped, but being able to drag magazines into the launcher slot is hacky and I just don't like it

Whigital · 2020-01-30T22:29:24Z

There we go, squashed, baked and magazines gone.

optionals/compat_rhs_afrf3/CfgWeapons.hpp

commy2 · 2020-01-31T07:04:11Z

Can you explain why:

            class MuzzleSlot {
                iconScale = 0.1;
            };

works?

Why list iconScale at all?
Why is it not set to 0 or 1?
Why is not an empty picture set instead?
What about the other attachment slots?

Whigital · 2020-01-31T10:24:31Z

Can you explain why:
            class MuzzleSlot {
                iconScale = 0.1;
            };
works?

Why list iconScale at all?
Why is it not set to 0 or 1?
Why is not an empty picture set instead?
What about the other attachment slots?

Basically just to trick the engine into using the weapon picture instead of looking for alternatives based on slots:

https://community.bistudio.com/wiki/Arma_3_Weapon_Config_Guidelines#Inventory_icons_overlay_method

If there is no slot with positive value of iconScale property, the game falls back to old behaviour

From what i could gather, the picture error is based on the engine looking for a picture with <classname>_x_ca.paa as baseLayer, <classname>_m_ca.paa for muzzle etc., if there are no slots with the iconScale property.

Can add the other slots and use an empty picture for them if it makes more sense.

commy2 · 2020-01-31T11:15:37Z

It wouldn't make more sense to add the other entries, however, I think this warrants a comment in the source code.

Whigital · 2020-01-31T14:12:51Z

Maybe add a macro for that class (MuzzleSlot) and comment that ?

// Fake muzzle slot to get weapon picture to display in inventory, ref.
// https://community.bistudio.com/wiki/Arma_3_Weapon_Config_Guidelines#Inventory_icons_overlay_method

#define FAKE_MUZZLE_SLOT class MuzzleSlot { iconScale = 0.1; };

commy2 · 2020-01-31T14:39:45Z

Not sure about macro. It would be enough if the first occurance in the config is commented.

I'd chose a better comment though, i.e.:

// Positive value for iconScale forces game to use icon overlay method.
// Required, because the inventory icon has no accessory variants.

FAKE_MUZZLE_SLOT is a poor name, imo. One should use the self documenting possibilities when chosing a macro name. I.e. FIX_INVENTORY_ICON;

…taticAACarry

PabstMirror added this to the 3.13.1 milestone Jan 29, 2020

PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jan 29, 2020

commy2 reviewed Jan 29, 2020

View reviewed changes

optionals/compat_rhs_afrf3/CfgWeapons.hpp Outdated Show resolved Hide resolved

commy2 reviewed Jan 29, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

Whigital added 5 commits January 30, 2020 23:17

Add magazines to carryable statics

93173d4

Remove CSW mag defs

62a7db5

Remove USAF mag defs

bd90b1a

Remove AFRF mag defs

9aacdf3

Remove GREF mag defs

0b4a38d

Whigital force-pushed the csw_mags_zeus branch from 9e99dae to 0b4a38d Compare January 30, 2020 22:26

Whigital changed the title ~~[csw] Add compatible mags and enable Arsenal listing~~ [csw] Minor bugfixes Jan 30, 2020

commy2 reviewed Jan 31, 2020

View reviewed changes

optionals/compat_rhs_afrf3/CfgWeapons.hpp Show resolved Hide resolved

Whigital added 4 commits January 31, 2020 18:31

Update CSW author fields and remove inherited properties on ace_csw_s…

7e91ffc

…taticAACarry

Update USAF with WeaponSlot comment

cf732c1

Update AFRF with WeaponSlot comment and author property

b4ac330

Update GREF with WeaponSlot comment

95c213f

commy2 approved these changes Jan 31, 2020

View reviewed changes

Whigital changed the title ~~[csw] Minor bugfixes~~ CSW - Minor fixes for CSW + RHS Compats Feb 12, 2020

commy2 merged commit af777a4 into acemod:master Feb 22, 2020

jonpas approved these changes Feb 22, 2020

View reviewed changes

Whigital deleted the csw_mags_zeus branch February 29, 2020 01:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CSW - Minor fixes for CSW + RHS Compats #7497

CSW - Minor fixes for CSW + RHS Compats #7497

Whigital commented Jan 29, 2020 •

edited

Loading

commy2 commented Jan 29, 2020

commy2 commented Jan 29, 2020

Whigital commented Jan 29, 2020

commy2 commented Jan 29, 2020

commy2 Jan 29, 2020

Whigital Jan 29, 2020

commy2 Jan 29, 2020

Whigital Jan 30, 2020

veteran29 Jan 30, 2020

Whigital commented Jan 29, 2020

commy2 commented Jan 29, 2020

commy2 commented Jan 29, 2020 •

edited

Loading

Whigital commented Jan 29, 2020

This comment has been minimized.

This comment has been minimized.

Whigital commented Jan 29, 2020

Whigital commented Jan 30, 2020

veteran29 commented Jan 30, 2020

dedmen commented Jan 30, 2020

Whigital commented Jan 30, 2020

PabstMirror commented Jan 30, 2020

TheCandianVendingMachine commented Jan 30, 2020

Whigital commented Jan 30, 2020

commy2 commented Jan 31, 2020

Whigital commented Jan 31, 2020

commy2 commented Jan 31, 2020

Whigital commented Jan 31, 2020 •

edited

Loading

commy2 commented Jan 31, 2020

CSW - Minor fixes for CSW + RHS Compats #7497

CSW - Minor fixes for CSW + RHS Compats #7497

Conversation

Whigital commented Jan 29, 2020 • edited Loading

commy2 commented Jan 29, 2020

commy2 commented Jan 29, 2020

Whigital commented Jan 29, 2020

commy2 commented Jan 29, 2020

commy2 Jan 29, 2020

Choose a reason for hiding this comment

Whigital Jan 29, 2020

Choose a reason for hiding this comment

commy2 Jan 29, 2020

Choose a reason for hiding this comment

Whigital Jan 30, 2020

Choose a reason for hiding this comment

veteran29 Jan 30, 2020

Choose a reason for hiding this comment

Whigital commented Jan 29, 2020

commy2 commented Jan 29, 2020

commy2 commented Jan 29, 2020 • edited Loading

Whigital commented Jan 29, 2020

This comment has been minimized.

This comment has been minimized.

Whigital commented Jan 29, 2020

Whigital commented Jan 30, 2020

veteran29 commented Jan 30, 2020

dedmen commented Jan 30, 2020

Whigital commented Jan 30, 2020

PabstMirror commented Jan 30, 2020

TheCandianVendingMachine commented Jan 30, 2020

Whigital commented Jan 30, 2020

commy2 commented Jan 31, 2020

Whigital commented Jan 31, 2020

commy2 commented Jan 31, 2020

Whigital commented Jan 31, 2020 • edited Loading

commy2 commented Jan 31, 2020

Whigital commented Jan 29, 2020 •

edited

Loading

commy2 commented Jan 29, 2020 •

edited

Loading

Whigital commented Jan 31, 2020 •

edited

Loading