Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical Status - Fix double execution of killed event #7561

Merged
merged 4 commits into from
Feb 29, 2020

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Feb 28, 2020

When merged this pull request will:

bob1 addEventHandler ["Killed", { 
    systemChat str ["Object Killed", _this]; 
}];

addMissionEventHandler ["EntityKilled", { 
    systemChat str ["Mission Killed", _this]; 
}];

Note that execNextFrame is how we killed units pre rewrite. The biggest issue was incorrect returns, but Pabst solved that independently and removed my reason for moving setDamage into HandleDamage in the first place.

Secondary execution runs with null objects. Should dedmen fix https://feedback.bistudio.com/T149510, the issue will be gone.

@commy2 commy2 added the kind/bug-fix Release Notes: **FIXED:** label Feb 28, 2020
@commy2 commy2 added this to the 3.13.1 milestone Feb 28, 2020
@jonpas jonpas changed the title fix double execution of killed event Medical Status - Fix double execution of killed event Feb 28, 2020
@jonpas jonpas changed the title Medical Status - Fix double execution of killed event Medical Status - Fix double execution of killed event Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACE Arsenal VR Targets duplicating when killed Server not counting killsInfantry
2 participants