Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick Mount: Check vehicle simulation #7886

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Quick Mount: Check vehicle simulation #7886

merged 1 commit into from
Sep 3, 2020

Conversation

Cyruz143
Copy link
Contributor

Stops players getting to vehicles with simulation disabled

  • You can currently mount in a vehicle witih sim disabled and you get "stuck" inside. Vanilla addActions allow this too (I've asked Ded to see if he can fix). For now this at leasts stops people accidentally getting in to something they shouldn't with a bad key press.
  • Reusing the locked message as the player doesn't need to know the difference between locked/sim disabled, they just need to know they can't get in.
  • Possibly warrants an RPT line so if you get people complaining they cannot get in a vehicle, RPT shows why (#blamethemissionmaker) - Thoughts?

jonpas
jonpas approved these changes Aug 30, 2020
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@jonpas jonpas added this to the 3.14.0 milestone Aug 30, 2020
@jonpas jonpas added kind/enhancement Release Notes: **IMPROVED:** status/discussion labels Aug 30, 2020
@jonpas
Copy link
Member

jonpas commented Aug 31, 2020 •
edited
Loading

Possibly warrants an RPT line so if you get people complaining they cannot get in a vehicle, RPT shows why (#blamethemissionmaker) - Thoughts?

I don't think it's necessary, this is more an issue resolution than anything else.

@PabstMirror PabstMirror modified the milestones: 3.14.0, 3.13.5 Aug 31, 2020
@PabstMirror PabstMirror merged commit 38baa8d into acemod:master Sep 3, 2020
@Cyruz143 Cyruz143 deleted the quick_mount_fix branch September 10, 2020 13:03
@severgun severgun mentioned this pull request Sep 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 approved these changes

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:** status/discussion
Projects
None yet
Milestone
3.13.5
Development

Successfully merging this pull request may close these issues.
4 participants
@Cyruz143 @jonpas @mharis001 @PabstMirror