Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical - Add Treatment Time Addon Settings #7900

Merged
merged 3 commits into from
Oct 29, 2020

Conversation

dgibso29
Copy link
Contributor

@dgibso29 dgibso29 commented Sep 8, 2020

Adds treatment time addon settings for Tourniquets, IV Bags, Syringes, Splints, and Body Bags.

Each value has been defaulted to the current default time for each type, and has been set in a range [0.1, (currentDefault * 4)].

I have tested all 5 of these new settings without issue.

image

Thank you.

@Elgin675
Copy link
Contributor

Elgin675 commented Sep 9, 2020

Good idea :) ! But it doesn't "disturb" too much the animations ?

I have a suggestion. Would it be possible to add coefficients for medics/doctors ?
I think there is already an hardcoded coefficient for bandaging.

I'll redo the French translation if you don't mind, so that it's consistent with the rest of the mod's translations.

@dgibso29
Copy link
Contributor Author

dgibso29 commented Sep 9, 2020

@Elgin675

Good idea :) ! But it doesn't "disturb" too much the animations ?

Entirely possible, but ultimately that would be the user/community's choice were they to desire extraordinarily low treatment times. Default values mirror the current hard-coded values, so they'd have to go out of their way to choose something low.

This PR came about because our community generally does not use tourniquets due to their application time often being similar to bandages. Unless you happen to be hit badly in one limb, it's generally the 'better' choice to just take the extra few seconds to apply 2 bandages. My goal is to promote tourniquet use by halving the application time. Exposing the other treatment times was a natural extension of this. Configurable values > hard-coded IMO! :)

I have a suggestion. Would it be possible to add coefficients for medics/doctors ?
I think there is already an hardcoded coefficient for bandaging.

I considered exposing all 3 of these but didn't want to make too many changes in one go. I'll take another look and see what it will take to do so.

I'll redo the French translation if you don't mind, so that it's consistent with the rest of the mod's translations.

Please do!

@Cyruz143
Copy link
Contributor

Cyruz143 commented Sep 10, 2020

Good idea :) ! But it doesn't "disturb" too much the animations ?

I've been using a tweak to drop the tourniquet apply times to 1 second for a while, if the time is lower than some magic value, it just doesn't play the anim so it should be ok for people setting very low values.

@Elgin675
Copy link
Contributor

Understood, thank you @Cyruz143 !

@mharis001 mharis001 added the kind/enhancement Release Notes: **IMPROVED:** label Oct 6, 2020
@mharis001 mharis001 added this to the 3.13.5 milestone Oct 6, 2020
@PabstMirror PabstMirror merged commit 174223b into acemod:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants