Markers - Add timestamps

[Freddo3000]

When merged this pull request will:

• Add a checkbox when creating/editing markers to add a timestamp suffix.
• Requires a watch
• Move IDCs to macros.

Credit to @milaq for https://github.com/milaq/arma3_timemarkers from which this was inspired.

[BrettMayson]

Should instead be an option under direction, rather than tucked in the corner

[Freddo3000]

Should instead be an option under direction, rather than tucked in the corner

I figured that considering it ties into the description, it should be close to it. I also wanted to keep the vertical space down.

[BrettMayson]

I figured that considering it ties into the description, it should be close to it. I also wanted to keep the vertical space down.

Vertical space is less of a concern than UX, maybe it could go under description then rather than at the bottom to keep it closer to related fields (Description)

[Freddo3000]

[PabstMirror]

Freddo3000#1
I want to prevent this when editing markers

I tested an idea I had that uses a special asci char (that just looks like a space) to indicate that a timecode follows.
fnc_initInsertMarker:95

    if !((markerText GVAR(editingMarker)) isEqualTo "") then {
        // fill text input with text from marker which is being edited
        private _originalText = markerText GVAR(editingMarker);
        private _timeIndex = _originalText find ((toString [129]) + "["); // 129 just looks like a space
        if (_timeIndex > 0 ) then { _originalText = _originalText select [0,_timeIndex]; }; // stip off timecode
        _text ctrlSetText _originalText;
    };

fnc_onButtonClickConfirm:30

        "%1%2[%3%4]",
        ctrlText _description,
        toString [129],....

This means when you edit a marker it will automatically update the timecode instead of appending it.

[Drofseh]

I could see it being useful to have a history sometimes TEXT [1345] [1353] [1405].

Maybe a second button to add instead of replace?

[Freddo3000]

I could see it being useful to have a history sometimes TEXT [1345] [1353] [1405].

Maybe a second button to add instead of replace?

At that point you might as well place a new marker, imo.

[Drofseh]

I could see it being useful to have a history sometimes TEXT [1345] [1353] [1405].
Maybe a second button to add instead of replace?

At that point you might as well place a new marker, imo.

yah maybe...

[veteran29]

LGTM

[dedmen]

This doesn't seem right?
description, space, space, time

you give 4 parameter but only use 3, and the space seems wrong

[Freddo3000]

Yeah looks like I made a typo, should probably be "%1%2[%3%4]"

[commy2]

Yes, am-pm is completely broken in this pull request. Even if this part was repaired, am-pm will not be shown for 12 and 24-hours, and even if that part is repaired, it will show the wrong one.

Should all be fixed here: https://github.com/acemod/ACE3/pull/8034/files#diff-4b395ce5b5e0cc52ea30d46cdc2cb9d5fea1eb22d6ca4cfe885b60ef68b1e45eR48