Disarming - Add quantity to ace_disarming_dropItems event
#8232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vdauphin
changed the title
ace_disarming_dropItems event now return the shown right text in the item
Vdauphin
commented
Apr 25, 2021
5 tasks
jonpas
requested changes
Oct 10, 2021
It represent the number of items take by the player |
Co-authored-by: jonpas <jonpas33@gmail.com>
PabstMirror
approved these changes
Oct 11, 2021
|
Should we convert it to a number then? Right now it's a string number which makes no sense. |
|
I don't know if this could be something else |
The number of items removed should be show as number and not as text
PabstMirror
approved these changes
Oct 11, 2021
jonpas
approved these changes
Oct 11, 2021
jonpas
changed the title
ace_disarming_dropItems event now return the shown right text in the itemace_disarming_dropItems event
AndreasBrostrom
pushed a commit
to AndreasBrostrom/ACE3
that referenced
this pull request
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
ace_disarming_dropItemsevent now return the number of items removedStory from slack:
I am looking for an event fired when you remove items from a prisoner
I found this one but it doesn't return the number of items removed
ACE3/addons/disarming/functions/fnc_openDisarmDialog.sqf
Line 44 in 76676ee
The number of items to be removed is determined here I guess: https://github.com/acemod/ACE3/blob/76676eee462cb0bbe400a482561c148d8652b550/addons/disarming/functions/fnc_disarmDropItems.sqf
So I am considering adding a new event here but it doesn't look as easy as I was expecting