Attach - Fix vanilla NV Marker lifetime #8473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
approved these changes
Oct 7, 2021
PabstMirror
changed the title
AndreasBrostrom
pushed a commit
to AndreasBrostrom/ACE3
that referenced
this pull request
Dec 3, 2021
* Fix vanilla NV Marker lifetime * Empty lines * Fix whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fixed the lifetime for our ACE IRStrobe item in #8283, but we didn't fix the liftimes when attaching the vanilla strobes.
I thought about updating the blinking pattern too. But I think its better to have separate blinking patterns so player can choose what they want. (Also I tried updating the blinking pattern and stuff got F'ed with very quick short blinking)
This updates the lifetime for attached IRStrobe (NVG_TargetC) and thrown IRStrobe (NVG_TargetW).