Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - Fix inconsistencies in coding guidelines #8481

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

Whigital
Copy link
Contributor

@Whigital Whigital commented Oct 4, 2021

When merged this pull request will:

  • Fix some minor example inconsistencies in Development/Coding guidelines

Indentations consist of 4 spaces

if (call FUNC(myCondition)) then {
private _areAllAboveTen = true; // <- smallest feasable scope
{
if (_x >= 10) then {
_areAllAboveTen = false;
};
} forEach _anArray;
if (_areAllAboveTen) then {
hint "all values are above ten!";
};
}

if (call FUNC(myCondition)) then {
{
if (_x >= 10) then {
_areAllAboveTen = false;
};
} forEach _anArray;
if (_areAllAboveTen) then {
hint "all values are above ten!";
};
};

When using array notation [], always use a space between elements to improve code readability.

@jonpas jonpas added this to the Ongoing milestone Oct 4, 2021
@jonpas jonpas added area/documentation kind/enhancement Release Notes: **IMPROVED:** labels Oct 4, 2021
@jonpas
Copy link
Member

jonpas commented Oct 4, 2021

Great!

@PabstMirror PabstMirror modified the milestones: Ongoing, 3.14.0 Oct 5, 2021
@PabstMirror PabstMirror merged commit 6b05da7 into acemod:master Oct 5, 2021
@Whigital Whigital deleted the wiki_coding_inconsistencies branch October 6, 2021 16:47
AndreasBrostrom pushed a commit to AndreasBrostrom/ACE3 that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants