Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explosives - Fix objNull reported as source and instigator in BI handleDamage event for explosive triggered by timer #8647

Merged
merged 5 commits into from
Nov 7, 2021

Conversation

Vdauphin
Copy link
Contributor

@Vdauphin Vdauphin commented Oct 28, 2021

title

This fix only works on client. I don't know if this function is supposed to be call server side.
As workaround, we could check if player is not null and pass _explosive as instigator.

When merged this pull request will:

@Vdauphin Vdauphin changed the title Explosive - Fix ObjectNull is reported as source and instigator in BI handleDamage event Explosives - Fix objNull is reported as source and instigator in BI handleDamage event for explosive triggered by timer Oct 28, 2021
@PabstMirror PabstMirror added this to the 3.14.1 milestone Oct 29, 2021
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Oct 29, 2021
@PabstMirror
Copy link
Contributor

The only case it wouldn't be player is if someone is using the AI Speed Dial, which is probably rare
But it might be better to use c29622f
and pass the specific unit to this func

@PabstMirror
Copy link
Contributor

@Dahlgren
automaton checks for pboProject claim it failed with

onPlace = QUOTE([ARR_4(_this select 1, _this select 3 select 0, '#timer', _this select 0)] call FUNC(startTimer); false);
In File z\ace\addons\explosives\ACE_Triggers.hpp: circa Line 59 Unknown #

github action is using DePbo.7.97
latest free is 8.35 and it builds fine on that

we could also just change the 3rd arg to nil

Error from proProject:
```
onPlace = QUOTE([ARR_4(_this select 1, _this select 3 select 0, '#timer', _this select 0)] call FUNC(startTimer); false);
In File z\ace\addons\explosives\ACE_Triggers.hpp: circa Line 59 Unknown #
```
@jonpas jonpas changed the title Explosives - Fix objNull is reported as source and instigator in BI handleDamage event for explosive triggered by timer Explosives - Fix objNull reported as source and instigator in BI handleDamage event for explosive triggered by timer Nov 7, 2021
@jonpas jonpas merged commit c83caa6 into acemod:master Nov 7, 2021
@Vdauphin Vdauphin deleted the patch-5 branch November 7, 2021 23:31
AndreasBrostrom pushed a commit to AndreasBrostrom/ACE3 that referenced this pull request Dec 3, 2021
…andleDamage` event for explosive triggered by timer (acemod#8647)

Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants