-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explosives - Fix objNull
reported as source and instigator in BI handleDamage
event for explosive triggered by timer
#8647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vdauphin
changed the title
Explosive - Fix ObjectNull is reported as source and instigator in BI handleDamage event
Explosives - Fix objNull is reported as source and instigator in BI handleDamage event for explosive triggered by timer
Oct 28, 2021
LinkIsGrim
reviewed
Oct 29, 2021
3 tasks
The only case it wouldn't be player is if someone is using the AI Speed Dial, which is probably rare |
@Dahlgren
github action is using DePbo.7.97 we could also just change the 3rd arg to |
Error from proProject: ``` onPlace = QUOTE([ARR_4(_this select 1, _this select 3 select 0, '#timer', _this select 0)] call FUNC(startTimer); false); In File z\ace\addons\explosives\ACE_Triggers.hpp: circa Line 59 Unknown # ```
PabstMirror
approved these changes
Oct 30, 2021
jonpas
changed the title
Explosives - Fix objNull is reported as source and instigator in BI handleDamage event for explosive triggered by timer
Explosives - Fix Nov 7, 2021
objNull
reported as source and instigator in BI handleDamage
event for explosive triggered by timer
jonpas
approved these changes
Nov 7, 2021
AndreasBrostrom
pushed a commit
to AndreasBrostrom/ACE3
that referenced
this pull request
Dec 3, 2021
…andleDamage` event for explosive triggered by timer (acemod#8647) Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title
This fix only works on client. I don't know if this function is supposed to be call server side.As workaround, we could check if player is not null and pass _explosive as instigator.When merged this pull request will:
ACE3/addons/explosives/functions/fnc_detonateExplosive.sqf
Line 58 in 06336b8
ACE3/addons/explosives/XEH_postInit.sqf
Line 28 in 87cfd96