Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vehicles - Mousewheel will set speed limiter value to even multiples #8840

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Vehicles - Mousewheel will set speed limiter value to even multiples #8840

merged 2 commits into from
Mar 17, 2022

Conversation

PabstMirror
Copy link
Contributor

Before if you set speedlimter at 22
22->27->32

now
22->25->30

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Mar 9, 2022
@PabstMirror PabstMirror added this to the 3.14.2 milestone Mar 9, 2022
jonpas
jonpas approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeees!

@jokoho48
Copy link
Member

jokoho48 commented Mar 9, 2022

why only do that with 5? should this maybe be done always?

@PabstMirror
Copy link
Contributor Author

it's weird if the setting is something like 6.2, you get floating point rounding errors

@mharis001
Copy link
Member

mharis001 commented Mar 10, 2022 •
edited
Loading

Maybe change the setting to always be round numbers (_trailingDecimals to -1). It is already set to 0 (don't show decimals).

@PabstMirror PabstMirror changed the title Vehicles - Mousewheel will set speed limiter value to multiples of 5 Vehicles - Mousewheel will set speed limiter value to even multiples Mar 11, 2022
@PabstMirror PabstMirror merged commit 70f3f55 into master Mar 17, 2022
@PabstMirror PabstMirror deleted the speedLimitMulit5 branch March 17, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 approved these changes

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@PabstMirror @jokoho48 @mharis001 @jonpas