Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laser/Laserpointer - Fix localization of laser #8885

Merged
merged 1 commit into from
May 2, 2022

Conversation

Wakbub
Copy link
Contributor

@Wakbub Wakbub commented Apr 23, 2022

Add

  • laser: Add missing Hungarian translation of laser (BI doesn't have it translated).

Change

  • laser: Change localize to LLSTRING.

Fix

  • laser: Fix capitalization of laser. It's used in settings and looks off with only "laser" but no other setting in lowercase.
  • laserpointer: Fix Japanese translation of "Laser" to match the one in the laser module.

ToDo?

  • The same translation of "Laser" now exists in both the laser and laserpointer modules. Maybe it should be put in common?
  • "レーザー" and "レーザ" are mixed in the aforementioned modules. I guess the former should be used: a Japanese person I asked said the former is correct and the latter wrong, BI uses the former, Wikipedia redirects to the former, most dictionaries I've looked in translates "laser" to the former, but for some reason Google translates it to the latter.

Add
- `laser`: Add Hungarian translation of laser.

Fix
- `laser`: Fix capitalization of laser.
- `laserpointer`: Fix Japanese translation of laser.
@PabstMirror PabstMirror added this to the 3.14.2 milestone Apr 23, 2022
@PabstMirror PabstMirror added the kind/translation Release Notes: **TRANSLATIONS:** label Apr 23, 2022
@PabstMirror PabstMirror merged commit 70641c3 into acemod:master May 2, 2022
@Wakbub Wakbub deleted the laser branch October 11, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/translation Release Notes: **TRANSLATIONS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants