Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorize get subject session #1190

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maximemulder
Copy link
Contributor

@maximemulder maximemulder commented Sep 27, 2024

This PR (still a draft) extracts the "get subject session" operation out of BasePipeline, with the goal of making it easily reusable by all scripts, including those that do not use BasePipeline (new DICOM archive and eventually BIDS import). It also modernizes the database access by using the new SQLAlchemy abstractions.

This PR should eventually be split into several PRs to make it easier to review (sorted by dependency):

  • New SQLAlchemy abstractions
  • Move remaining subject validation logic into validate_subject_ids
  • Extract get_subject_session in its own file

Depends on:

Is depended on by:

@maximemulder maximemulder force-pushed the 2024-09-26_factorize-subject-session branch from c1aab1f to 917e939 Compare September 27, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant