Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module function isPublicModule() should return a bool #4282

Closed
driusan opened this issue Jan 28, 2019 · 3 comments · Fixed by #7758
Closed

Module function isPublicModule() should return a bool #4282

driusan opened this issue Jan 28, 2019 · 3 comments · Fixed by #7758
Labels
Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS Cleanup PR or issue introducing/requiring at least one clean-up operation Event: Hacktoberfest 2021 PR or issue accepted for Hacktoberfest 2021 State: Stale PR that has had no recent activity, needs to be triaged for review or closure to proceed

Comments

@driusan
Copy link
Collaborator

driusan commented Jan 28, 2019

The function signature in the Module class for isPublicModule should include a boolean return type (public function isPublicModule() : bool), which wasn't done in #4234.

It should be fairly easy to update it, but updating it will require changing every Module subclass in each modules/$modulaname/php directory.
@driusan driusan added Cleanup PR or issue introducing/requiring at least one clean-up operation Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS labels Jan 28, 2019
driusan pushed a commit that referenced this issue Jan 28, 2019
@johnsaigle @driusan
[Core] Add return types to Module class (#4234)
18b052b 
This adds return types to functions in the Module base class, except for isPublicModule(). Issue #4282 created for the latter.
@johnsaigle johnsaigle mentioned this issue Nov 27, 2019
Closed
@stale
Copy link

stale bot commented Jan 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the State: Stale PR that has had no recent activity, needs to be triaged for review or closure to proceed label Jan 26, 2020
@stale
Copy link

stale bot commented Feb 10, 2020

The Stale label is being removed automatically because some activity has occurred or because the developers have decided that this pull request is important and should not continue to be overlooked.

@stale stale bot removed the State: Stale PR that has had no recent activity, needs to be triaged for review or closure to proceed label Feb 10, 2020
@stale
Copy link

stale bot commented Apr 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the State: Stale PR that has had no recent activity, needs to be triaged for review or closure to proceed label Apr 10, 2020
@christinerogers christinerogers added the Event: Hacktoberfest 2021 PR or issue accepted for Hacktoberfest 2021 label Oct 5, 2021
driusan added a commit to driusan/Loris that referenced this issue Oct 29, 2021
@driusan
[Module] Add return type hint to isPublicModule
c7e7f4f 
Add a return type hint to the isPublicModule method.

Resolves aces#4282
@driusan driusan mentioned this issue Oct 29, 2021
Merged
driusan added a commit to driusan/Loris that referenced this issue Mar 29, 2022
@driusan
[Module] Add return type hint to isPublicModule
2685c0c 
Add a return type hint to the isPublicModule method.

Resolves aces#4282
driusan added a commit to driusan/Loris that referenced this issue Oct 24, 2022
@driusan
[Module] Add return type hint to isPublicModule
d83c8ca 
Add a return type hint to the isPublicModule method.

Resolves aces#4282
driusan added a commit that referenced this issue Oct 25, 2022
@driusan
[Module] Add return type hint to isPublicModule (#7758)
696543c 
Add a return type hint to the isPublicModule method.

Resolves #4282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS Cleanup PR or issue introducing/requiring at least one clean-up operation Event: Hacktoberfest 2021 PR or issue accepted for Hacktoberfest 2021 State: Stale PR that has had no recent activity, needs to be triaged for review or closure to proceed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Module] Add return type hint to isPublicModule driusan/Loris
[PHPCS] Make type hinting mandatory
3 participants
@driusan @christinerogers @johnsaigle