Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] EEG Uploader doesn't load data for EEG Browser #9191

Open
christinerogers opened this issue Apr 4, 2024 · 2 comments
Open

[Docs] EEG Uploader doesn't load data for EEG Browser #9191

christinerogers opened this issue Apr 4, 2024 · 2 comments
Assignees
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Document at Release PR adds or changes a feature such that the wiki (or other documentation) must be updated

Comments

@christinerogers
Copy link
Contributor

christinerogers commented Apr 4, 2024

Found and confirmed during 26 testing, it's an undocumented (non-)feature that should be explained to users until there is a solution. Per Testing meeting April 4:

EEG uploader module will upload but not insert(?) data into LORIS in a way that makes it visible in the EEG Browser module.

The current Readme of this module implies that the data should be visible in the EEG Browser (invokes same permissions, etc) even if it doesn't say it outright, which is misleading enough.

This is also contrary to pretty normal user expectations, so it should be addressed in the documentation, and also flagged as a To do issue for the next release (if only to avoid bug reports).

Actual solution might include (see Imaging for examples of each):

  • committing a script that runs the EEG insertion pipeline after an upload is processed
  • updating the test plan so that user checks both the Browse tab in this module and the EEG Browser module
  • updating the Readme to note interactions with the Server Process Manager
@christinerogers christinerogers added Document at Release PR adds or changes a feature such that the wiki (or other documentation) must be updated 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 labels Apr 4, 2024
@christinerogers christinerogers added this to the 26.0.0 milestone Apr 4, 2024
@driusan
Copy link
Collaborator

driusan commented Apr 4, 2024

@laemtl said there's a cron job to be set up to make it work, that should be documented in the Configurations section of the README.

@laemtl laemtl self-assigned this Apr 4, 2024
@christinerogers
Copy link
Contributor Author

this is more complex than initially thought:
pipeline change was required, and testing this is holding up this task.
pybids import needed specific structure of whole project, problematic to add the second candidate. .

found in loading partial datasets troubleshooting

Samir to try re-resourcing (eeg meeting, may 17)

github-merge-queue bot pushed a commit that referenced this issue Jun 10, 2024
Documentation patch to resolve #9293.

Let users and admins know that they will encounter a known issue
(#9191), not a bug with their setup:

This does this by: 
- Adding text visible to Users at the top of the module 
- Adding README message
- Adding Help text note for users

This does not resolve #9191, but it clarifies the state for LORIS users.
@ridz1208 ridz1208 removed this from the 26.0.0 milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Document at Release PR adds or changes a feature such that the wiki (or other documentation) must be updated
Projects
None yet
Development

No branches or pull requests

4 participants