[Core: Utility] Add type declarations to function signatures #4046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
added
Category: Cleanup
johnsaigle
commented
Oct 31, 2018
PapillonMcGill
suggested changes
Nov 5, 2018
php/libraries/Utility.class.inc
Outdated
| * @return array an associative array("SubprojectID" => "Subproject title") | ||
| */ | ||
| static function getSubprojectList($projectID = null) | ||
| static function getSubprojectList(int $projectID = null): array |
Contributor
There was a problem hiding this comment.
I know Travis is happy but should't it be ?int $projectID = null (same for line 257)?
At least use the same form for both and lines 409, 441, 752-756, 771-773
PapillonMcGill
approved these changes
Nov 12, 2018
2 tasks
driusan
pushed a commit
that referenced
this pull request
Dec 22, 2020
Fix display of subprojects on stats demographic broken in PR #4046
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
Fix display of subprojects on stats demographic broken in PR aces#4046
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3878 for a more detailed description.
This PR also fixes problematic calling classes in the statistics module.