[instrument_manager] Use JSON data for uploaded linst instruments #9324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the instrument_manager to create a .meta file for uploaded LINST instruments to use JSON for saving data, rather than running the generate_tables_and_test_names script. This is more robust, doesn't require exec'ing mysql, doesn't require create table permission for the upload, and better aligns with LORIS best practices to use JSON instead of table data by default.
driusan
added
Add to Release Notes
ridz1208
approved these changes
Aug 20, 2024
maximemulder
pushed a commit
to maximemulder/Loris
that referenced
this pull request
Sep 25, 2024
…es#9324) This updates the instrument_manager to create a .meta file for uploaded LINST instruments to use JSON for saving data, rather than running the generate_tables_and_test_names script. This is more robust, doesn't require exec'ing mysql, doesn't require create table permission for the upload, and better aligns with LORIS best practices to use JSON instead of table data by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the instrument_manager to create a .meta file for uploaded LINST instruments to use JSON for saving data, rather than running the generate_tables_and_test_names script. This is more robust, doesn't require exec'ing mysql, doesn't require create table permission for the upload, and better aligns with LORIS best practices to use JSON instead of table data by default.