Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several fixes all bundled together. #832

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Several fixes all bundled together. #832

merged 2 commits into from
Jul 2, 2019

Conversation

prioux
Copy link
Member

@prioux prioux commented Jun 27, 2019

1- The controls channel for Bourreau has a new 'StopYourself'
command, which is much more efficient than the old way
of stopping the rails app using an external script.
Fixes #55 .
2- The 'ibc' utility provides access to it with the 'J' command
3- Tooltips in the interface could never be positioned
at offset_x set to 0 because 0 is falsy in javascript. Fixed.
4- We no longer ever keep a backup of database.yml on remote sites.
5- Userfiles viewers that have conditions which crash no
longer prevent the 'show' page from rendering; instead the
viewer is ignored and removed from the available list.
Fixes #25
6- Task forms for boutiques tasks will present list
inputs in proper order.
Fixes #830
7- Support for lists for File inputs in boutiques
Fixes #831
8- When erasing a task, if the associated archive cannot be erased too
it will be tagged with the admin-owned Tag 'TaskDestroyed', so the
admin can find them and deleted them separately later.
Fixes #45

1- The controls channel for Bourreau has a new 'StopYourself'
   command, which is much more efficient than the old way
   of stopping the rails app using an external script.
   Fixes aces#55 .
2- The 'ibc' utility provides access to it with the 'J' command
3- Tooltips in the interface could never be positioned
   at offset_x set to 0 because 0 is falsy in javascript. Fixed.
4- We no longer ever keep a backup of database.yml on remote sites.
5- Userfiles viewers that have conditions which crash no
   longer prevent the 'show' page from rendering; instead the
   viewer is ignored and removed from the available list.
   Fixes aces#25
6- Task forms for boutiques tasks will present list
   inputs in proper order.
   Fixes aces#830
7- Support for lists for File inputs in boutiques
   Fixes aces#831
# command to be sent locally, and then the rails app will kill itself with
# a TERM signal, thus exiting right after the current request. The user should
# really make sure the workers are inactive and there is no other background
# activity.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to do in the future, or is there a reason you are not making this check?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we can't really make the check: once background activity is started it's forked into a separate process completely disconnected from the rails server (using double fork). So the rails server doesn't know if a background process is also using the DB.

K = stops bourreaux (using shell commands)
J = stops workers and bourreaux (using command control
messages; use this only if you're sure no workers
are active and the SSH masters are opened)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see, so still dangerous, but only done by an experienced admin.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, an admin who can run the 'ps' command first.

Copy link
Contributor

@MontrealSergiy MontrealSergiy Jul 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and fast one :)

(seems fine thought theoretically with some effort some signaling or mutex mechanism can be implemented to avoid the issue)

@prioux
Copy link
Member Author

prioux commented Jul 2, 2019

I added on more feature: when a singularity build fails, we get a capture of the failed command. Fix #833 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants