Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys crates aren't actually built #1

Open
mfarrugi opened this issue Jan 29, 2018 · 1 comment · May be fixed by #5
Open

sys crates aren't actually built #1

mfarrugi opened this issue Jan 29, 2018 · 1 comment · May be fixed by #5

Comments

@mfarrugi
Copy link

miniz-sys and backtrace-sys aren't being linked, so the build won't fail until trying to build a dependent crate.

This probably applies to any crate with a build.rs that isn't run or replaced.
@acmcarther
Copy link
Owner

oops.

Action Item for me: add a hello_world that includes all of the crates, and add gen_buildrs = true to miniz-sys and backtrace-sys.

zoidyzoidzoid added a commit to zoidyzoidzoid/cargo-raze-crater that referenced this issue Jan 22, 2020
@zoidyzoidzoid
We need to generate some build.rs's
1e0fda1 
Closes acmcarther#1
@zoidyzoidzoid zoidyzoidzoid linked a pull request Jan 22, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

We need to generate some build.rs's zoidyzoidzoid/cargo-raze-crater
2 participants
@acmcarther @mfarrugi