-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report bug to nic.ru dns api #2547
Comments
For example, I had a DNS record with the value I think that this problem can be fixed by using the double dash: |
@slalik tell me which line ? |
Line 92 that contains |
@slalik
|
Thank you! I don't know how to do a real test, the problem happens only when the value of DNS record starts with dash. But it should work. |
I think the name of parameter NIC_Token is inconvenient. Please correct instruction at https://github.com/Neilpang/acme.sh/wiki/dnsapi#89-use-nicru-dns |
|
I can offer pull request in a few days. |
@slalik fixed. try again with dev branch
|
I think we can easily change NIC_Token parameter and break backward compatibility, but changing docs is better way. |
@rserpent please send PR |
It works, thank you! |
I'd sent PR 2678 export NIC_Username='000000/NIC-D'
export NIC_Password='xxxxxxxx'
export NIC_ClientID='xxxxxxxx'
export NIC_ClientSecret='xxxxxxxx' New behavior is backward compatible with old implementation |
There is bug at line 149 in _service=$(printf "%s" "$response" | grep "$_domain" | sed -r "s/.*service=\"(.*)\".*$/\1/") In my case <?xml version="1.0" encoding="UTF-8" ?>
<response>
<status>success</status>
<data>
<zone ... idn-name="sunnysmile.ru" name="sunnysmile.ru" service="prst-zorin-ru" />
<zone ... idn-name="zorina.ru" name="zorina.ru" service="prst-zorin-ru" />
<zone ... idn-name="zorin.ru" name="zorin.ru" service="prst-zorin-ru" />
</data>
</response> This causes error in log:
This bug was fixed in PR 2678 mentioned above |
#2678 had been merged. |
I have same problem:
acme.sh version 2.8.7 What can i do about it? |
I figured out this problem: |
@Sergey-Zorin Could you please check this small fix for regression. Thx |
Looks like nic.ru changed something in their API. About 2 weeks ago my script start to generate the following error trying to issue new certs:
I fixed it changed line 138 in dns_nic.sh |
Confirm this problem
-----Original Message-----
From: Aleksey Tasenko ***@***.***>
To: "acmesh-official/acme.sh" ***@***.***>
Cc: Alexilmarranen ***@***.***>, Manual ***@***.***>
Sent: чт, 11 авг. 2022 16:10
Subject: Re: [acmesh-official/acme.sh] Report bug to nic.ru dns api (#2547)
Looks like nic.ru changed something in their API. About 2 weeks ago my script start to generate the following error trying to issue new certs:
[Thu Aug 11 11:21:02 MSK 2022] Token received
[Thu Aug 11 11:21:02 MSK 2022] _auth_token='token_type:Bearer'
[Thu Aug 11 11:21:02 MSK 2022] First detect the root zone
[Thu Aug 11 11:21:02 MSK 2022] zones
[Thu Aug 11 11:21:02 MSK 2022] GET
[Thu Aug 11 11:21:02 MSK 2022] url='https://api.nic.ru/dns-master/zones'
[Thu Aug 11 11:21:02 MSK 2022] timeout=
[Thu Aug 11 11:21:02 MSK 2022] Http already initialized.
[Thu Aug 11 11:21:02 MSK 2022] _CURL='curl --silent --dump-header /usr/local/letsencrypt/http.header -L --trace-ascii /tmp/tmp.rZAQStqtWW -g '
[Thu Aug 11 11:21:02 MSK 2022] ret='0'
[Thu Aug 11 11:21:02 MSK 2022] Error: Access token expired or not found
[Thu Aug 11 11:21:02 MSK 2022] Invalid domain
[Thu Aug 11 11:21:02 MSK 2022] Error add txt for domain:_acme-challenge.mydomain.ru
[Thu Aug 11 11:21:02 MSK 2022] _on_issue_err
I fixed it changed line 138 in dns_nic.sh
` _auth_token=$(printf "%s" "$res" | cut -d , -f1 | tr -d "{" | tr -d "\"" | sed "s/access_token://")
`
…--
Reply to this email directly or view it on GitHub:
#2547 (comment)
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
I confirm the fix is correct - I checked it on four installations with three domains (including in the pfSense bsd port) @atasenko Can you create a PR? |
Hello
|
Not working: |
Probably, your case is not a bug, but an edge case of processing information from the api about zones and domains available on them. Please provide more information (with a higher debug level) about the process. Pay special ATTENTION to the presence of authentication information in the logs before publication. P.S. Since I think that this is not a bug, I can try to help solve this problem - write to me by email in bio. |
Sorry but i see only a part of your email ) |
This is the place to report bugs in the nic.ru DNS API.
If you experience a bug, please report it in this issue.
Thanks!
The text was updated successfully, but these errors were encountered: