From 86e76bd06327f92e9b807fd466a69b807d705627 Mon Sep 17 00:00:00 2001 From: miguelbirdie Date: Tue, 27 Jun 2023 08:34:09 +0200 Subject: [PATCH 1/2] feat(cron): Adding more parameters to ingestion-cron --- .../templates/cron.yaml | 6 +++++- .../datahub-ingestion-cron/values.yaml | 20 +++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/charts/datahub/subcharts/datahub-ingestion-cron/templates/cron.yaml b/charts/datahub/subcharts/datahub-ingestion-cron/templates/cron.yaml index be3ae29b9..ad8fdb425 100644 --- a/charts/datahub/subcharts/datahub-ingestion-cron/templates/cron.yaml +++ b/charts/datahub/subcharts/datahub-ingestion-cron/templates/cron.yaml @@ -9,8 +9,12 @@ metadata: labels: {{- $labels | nindent 4 }} spec: schedule: {{ default "0 0 * * *" .schedule | quote}} + concurrencyPolicy: {{ default "Allow" .concurrencyPolicy }} + successfulJobsHistoryLimit: {{ default 3 .successfulJobsHistoryLimit }} + failedJobsHistoryLimit: {{ default 1 .failedJobsHistoryLimit }} jobTemplate: spec: + backoffLimit: {{ default 6 $val.backoffLimit }} template: {{- with $val.podAnnotations }} metadata: @@ -60,7 +64,7 @@ spec: key: {{ $value.key | quote}} {{- end }} {{- end }} - restartPolicy: OnFailure + restartPolicy: {{ default "OnFailure" .restartPolicy }} volumes: - name: recipe configMap: diff --git a/charts/datahub/subcharts/datahub-ingestion-cron/values.yaml b/charts/datahub/subcharts/datahub-ingestion-cron/values.yaml index 157960488..3e5db76e3 100644 --- a/charts/datahub/subcharts/datahub-ingestion-cron/values.yaml +++ b/charts/datahub/subcharts/datahub-ingestion-cron/values.yaml @@ -66,6 +66,26 @@ crons: {} ## #podAnnotations: {} + ## Add your own restartPolicy + ## + #restartPolicy: + + ## Add your own concurrencyPolicy + ## + #concurrencyPolicy: + + ## Add your own failedJobsHistoryLimit + ## + #failedJobsHistoryLimit: + + ## Add your own successfulJobsHistoryLimit + ## + #successfulJobsHistoryLimit: + + ## Add your own backoffLimit + ## + #backoffLimit: + # Add extra sidecar containers to deployment pod extraSidecars: [] # - name: my-image-name From 7b5e71ba96cf016c33ee23c8307a4c839f865164 Mon Sep 17 00:00:00 2001 From: david-leifker <114954101+david-leifker@users.noreply.github.com> Date: Tue, 27 Jun 2023 15:34:58 -0500 Subject: [PATCH 2/2] Update Chart.yaml --- charts/datahub/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/datahub/Chart.yaml b/charts/datahub/Chart.yaml index 073aeef1c..41bd49d88 100644 --- a/charts/datahub/Chart.yaml +++ b/charts/datahub/Chart.yaml @@ -4,7 +4,7 @@ description: A Helm chart for LinkedIn DataHub type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. -version: 0.2.176 +version: 0.2.177 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. appVersion: 0.10.4