Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct descriptions of failed examples in valid language tag rule #2194

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Correct descriptions of failed examples in valid language tag rule #2194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions _rules/html-page-lang-valid-bf051a.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,23 +90,23 @@ This `html` element has a `lang` attribute with a [known primary language tag][]

#### Failed Example 1

This `html` element has a `lang` attribute with a [known primary language tag][].
This `html` element has a `lang` attribute, but it is not a [known primary language tag][].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This `html` element has a `lang` attribute, but it is not a [known primary language tag][].
This `html` element has a `lang` attribute, with no [known primary language tag][].

The value of the lang attribute is not (and does not need to be) a primary language tag, only the, well, primary tag needs to be.


```html
<html lang="em-US"></html>
```

#### Failed Example 2

This `html` element has a `lang` attribute with a [known primary language tag][].
This `html` element has a `lang` attribute, but it is not a [known primary language tag][].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This `html` element has a `lang` attribute, but it is not a [known primary language tag][].
This `html` element has a `lang` attribute, with no [known primary language tag][].


```html
<html lang="#1"></html>
```

#### Failed Example 3

The `lang` attribute of this page is an [iso 639.2][] three letters code, which has no [known primary language tag][].
The `lang` attribute of this page is an [iso 639.2][] three-letter code, which has no [known primary language tag][].

```html
<html lang="eng">
Expand Down
Loading