fix field names conflicts #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI @fruiting! Thanks for the PR. I'm not open to adding any new fixed prefixes or fixed suffixes to the generated field names to avoid conflicts, because inevitably these names will conflict with someone's naming scheme. If you PRed a change to use a templated name I would be open to merging that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I found such case:
We have field named "foo" in our schema and gogen-avro makes constructor method named NewFoo()
Also we have field named "newFoo". After code generating we have conflict of struct NewFoo and constructor method name NewFoo() from field "foo".
I made a fix for that case