Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 support for runners #6459

Closed
5 of 12 tasks
wbarnha opened this issue Oct 24, 2022 · 17 comments
Closed
5 of 12 tasks

Add Python 3.11 support for runners #6459

wbarnha opened this issue Oct 24, 2022 · 17 comments
Assignees

Comments

@wbarnha
Copy link

wbarnha commented Oct 24, 2022

Tool name

Python

Tool license

PSF-2.0

Add or update?

  • Add
  • Update

Desired version

3.11

Approximate size

No response

Brief description of tool

Python 3.11 was released today on https://www.python.org/downloads/, can we get this added so that it's available in python-versions and setup-python?

URL for tool's homepage

No response

Provide a basic test case to validate the tool's functionality.

No response

Platforms where you need the tool

  • Azure DevOps
  • GitHub Actions

Runner images where you need the tool

  • Ubuntu 18.04
  • Ubuntu 20.04
  • Ubuntu 22.04
  • macOS 10.15
  • macOS 11
  • macOS 12
  • Windows Server 2019
  • Windows Server 2022

Can this tool be installed during the build?

No response

Tool installation time in runtime

No response

Are you willing to submit a PR?

If I know where to make the necessary changes in the repo, I'd be happy to make a PR.

@erik-bershel erik-bershel added awaiting-deployment Code complete; awaiting deployment and/or deployment in progress needs eyes and removed needs triage awaiting-deployment Code complete; awaiting deployment and/or deployment in progress labels Oct 25, 2022
@erik-bershel
Copy link
Contributor

@wbarnha
Hi! We'll take a look.

@mikhailkoliada
Copy link
Contributor

We will deploy it as soon as it is in the python-version repo

@AntonOfTheWoods
Copy link

@mikhailkoliada , is there are more detailed description of the workflow somewhere? python-version says:

Adding new versions
We are trying to build and release new versions of Python as soon as they are released. Please open an issue in [actions/virtual-environments](https://github.com/actions/virtual-environments) if any versions are missing.

Is that basically saying that the maintainers of that repo look at these issues and then add what is required there, which will then get picked up here?

@mikhailkoliada
Copy link
Contributor

@AntonOfTheWoods we have a number of workflow in the python-versions repo which are responsible for repackaging a specific python version or building it from the source code and publish a new release there, then versions-manifest.json is updated with the new versions.

Finally we parse versions-manifest.json to get all the latest python major-minor versions for a specific release.

@mdshw5
Copy link

mdshw5 commented Oct 25, 2022

As this issue is tagged with OS: macOS, but macOS runner images were not specified in the description, will python 3.11.0 macOS builds be produced? I'm testing against 3.11.0 using the macOS image in mdshw5/pyfaidx#197. Thanks for all your work maintaining these important resources!

@erik-bershel
Copy link
Contributor

@mdshw5 similar changes are planned for macOS too.

jeeb added a commit to jeeb/mpv that referenced this issue Nov 11, 2022
… on macOS

This way each time a new Python version is installed via Homebrew
, we don't get CI failures due to the upstream Python distribution
also being installed.

Ref: actions/runner-images#6459
Ref: actions/runner-images#2322
jeeb added a commit to jeeb/mpv that referenced this issue Nov 11, 2022
… on macOS

This way each time a new Python version is installed via Homebrew
, we don't get CI failures due to the upstream Python distribution
also being installed.

Ref: actions/runner-images#6459
Ref: actions/runner-images#2322
jeeb added a commit to jeeb/mpv that referenced this issue Nov 11, 2022
… on macOS

This way each time a new Python version is installed via Homebrew
, we don't get CI failures due to the upstream Python distribution
also being installed.

Ref: actions/runner-images#6459
Ref: actions/runner-images#2322
jeeb added a commit to jeeb/mpv that referenced this issue Nov 11, 2022
… on macOS

This way each time a new Python version is installed via Homebrew
, we don't get CI failures due to the upstream Python distribution
also being installed.

Ref: actions/runner-images#6459
Ref: actions/runner-images#2322
jeeb added a commit to jeeb/mpv that referenced this issue Nov 11, 2022
… on macOS

This way each time a new Python version is installed via Homebrew
, we don't get CI failures due to the upstream Python distribution
also being installed.

Ref: actions/runner-images#6459
Ref: actions/runner-images#2322
jeeb added a commit to jeeb/mpv that referenced this issue Nov 11, 2022
… on macOS

This way each time a new Python version is installed via Homebrew
, we don't get CI failures due to the upstream Python distribution
also being installed.

Ref: actions/runner-images#6459
Ref: actions/runner-images#2322
jeeb added a commit to jeeb/mpv that referenced this issue Nov 11, 2022
… on macOS

This way each time a new Python version is installed via Homebrew
, we don't get CI failures due to the upstream Python distribution
also being installed.

Ref: actions/runner-images#6459
Ref: actions/runner-images#6507
Ref: actions/runner-images#2322
jeeb added a commit to mpv-player/mpv that referenced this issue Nov 11, 2022
… on macOS

This way each time a new Python version is installed via Homebrew
, we don't get CI failures due to the upstream Python distribution
also being installed.

Ref: actions/runner-images#6459
Ref: actions/runner-images#6507
Ref: actions/runner-images#2322
@eli-schwartz
Copy link

We're now hitting immediate brew install failures in Meson CI too, because homebrew LLVM has been rebuilt to depend on python@3.11.

rdzman added a commit to MATPOWER/mp-element that referenced this issue Nov 16, 2022
rdzman added a commit to MATPOWER/matpower that referenced this issue Nov 16, 2022
@szanni
Copy link

szanni commented Nov 17, 2022

We're now hitting immediate brew install failures in Meson CI too, because homebrew LLVM has been rebuilt to depend on python@3.11.

Confirmed.

 ==> Pouring python@3.11--3.11.0.big_sur.bottle.tar.gz
The formula built, but is not symlinked into /usr/local
Error: The `brew link` step did not complete successfully
Could not symlink bin/2to3-3.11
Target /usr/local/bin/2to3-3.11
already exists. You may want to remove it:
  rm '/usr/local/bin/2to3-3.11'

To force the link and overwrite all conflicting files:
  brew link --overwrite python@3.11

To list all files that would be deleted:
  brew link --overwrite --dry-run python@3.11

Possible conflicting files are:
/usr/local/bin/2to3-3.11 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/2to3-3.11
/usr/local/bin/idle3.11 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/idle3.11
/usr/local/bin/pydoc3.11 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/pydoc3.11
/usr/local/bin/python3.11 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/python3.11
/usr/local/bin/python3.11-config -> /Library/Frameworks/Python.framework/Versions/3.11/bin/python3.11-config

build.yml was working perfectly fine just a while ago.

@banach-space
Copy link

Can anyone else confirm?

Same issue in llvm-tutor when trying to install lit.

@mikhailkoliada
Copy link
Contributor

Hi all, sorry for delays! We will take a closer look to conflict

@mikhailkoliada
Copy link
Contributor

Deployed, though in brew python is still not updated to 3.11 on images.

q3aiml added a commit to q3aiml/ledger that referenced this issue Jan 8, 2023
The github mac runner images added python 3.11 but, unlike 3.10, not via
brew. This causes brew install to fail with link conflict errors now
that boost-python3 switched over to 3.11. Workaround this, and future
python brew link errors, by ovewriting all links for python packages.

Homebrew/homebrew-core@8c79089
https://github.com/orgs/Homebrew/discussions/3895
actions/setup-python#577
actions/runner-images#6459
actions/runner-images#6507
actions/runner-images#2322
q3aiml added a commit to q3aiml/ledger that referenced this issue Jan 8, 2023
The github mac runner images added python 3.11 but, unlike 3.10, not via
brew. This causes brew install to fail with link conflict errors now
that boost-python3 switched over to 3.11. Workaround this, and future
python brew link errors, by overwriting all links for python packages.

Homebrew/homebrew-core@8c79089
https://github.com/orgs/Homebrew/discussions/3895
actions/setup-python#577
actions/runner-images#6459
actions/runner-images#6507
actions/runner-images#2322
tbm pushed a commit to ledger/ledger that referenced this issue Jan 9, 2023
The github mac runner images added python 3.11 but, unlike 3.10, not via
brew. This causes brew install to fail with link conflict errors now
that boost-python3 switched over to 3.11. Workaround this, and future
python brew link errors, by overwriting all links for python packages.

Homebrew/homebrew-core@8c79089
https://github.com/orgs/Homebrew/discussions/3895
actions/setup-python#577
actions/runner-images#6459
actions/runner-images#6507
actions/runner-images#2322
dyphire pushed a commit to dyphire/mpv that referenced this issue Feb 22, 2023
… on macOS

This way each time a new Python version is installed via Homebrew
, we don't get CI failures due to the upstream Python distribution
also being installed.

Ref: actions/runner-images#6459
Ref: actions/runner-images#6507
Ref: actions/runner-images#2322
dyphire pushed a commit to dyphire/mpv that referenced this issue Feb 22, 2023
… on macOS

This way each time a new Python version is installed via Homebrew
, we don't get CI failures due to the upstream Python distribution
also being installed.

Ref: actions/runner-images#6459
Ref: actions/runner-images#6507
Ref: actions/runner-images#2322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests