Add support for Oracle JDK #401

fniephaus · 2022-11-04T15:07:10Z

Description:
This PR adds Oracle JDK to the list of supported distributions.

Related issue: #69

Check list:

Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.

brunoborges

LGTM

fniephaus · 2022-11-15T08:31:13Z

Thanks for approving, @brunoborges. I just pushed a commit that should make the tests work on macOS and Windows.

dmitry-shibanov · 2022-11-16T13:37:24Z

src/distributions/oracle/installer.ts

+
+  protected async findPackageForDownload(range: string): Promise<JavaDownloadRelease> {
+    const arch = this.distributionArchitecture();
+    if (arch !== 'x64' && arch !== 'aarch64') {


I think Oralce provides java binaries for aarch64.

Yes. Oracle does provide x64 and aarch64 binaries for Linux and macOS. That's why this check throws an error for non-x64 and non-aarch64 architectures.

Note: no aarch64 binaries for Windows, though https://www.oracle.com/java/technologies/downloads/

Related part in the tests: https://github.com/actions/setup-java/pull/401/files#diff-14331bf7630250eee172ff240c74a608009a7580b009948f84e3af1ea00f328eR76

dmitry-shibanov · 2022-11-16T13:37:27Z

src/distributions/oracle/installer.ts

+    if (parseInt(major) < 17) {
+      throw new Error('Oracle JDK is only supported for JDK 17 and later');
+    }


I think we can remove and add it to the documentation because if the versions is not found it will return 404 code. It can be handled further code checks.

Adding this limitation to the documentation is a good point.

Keeping it here has also an additional value, as users passing lower values for Java's "major" version will see an explicit error message that this vendor only supports "JDK 17 and later".

There's also the following note in https://github.com/actions/setup-java#supported-distributions section.

NOTE: The different distributors can provide discrepant list of available versions / supported configurations. Please refer to the official documentation to see the list of supported versions.

Doesn't this suffice?

dmitry-shibanov · 2022-11-16T13:39:42Z

Hello @fniephaus. Could you please update documentation for advanced configuration with examples for Oracle JDK ? Besides, If I understood correctly, it is impossible to grab all versions from API ?

sormuras · 2022-11-16T14:31:35Z

Could you please update documentation for advanced configuration with examples for Oracle JDK ?

I'll add an example to https://github.com/actions/setup-java/blob/main/docs/advanced-usage.md

Besides, If I understood correctly, it is impossible to grab all versions from API ?

What do you mean with "grab all version from API" ?

Find a list and a description of supported versions at https://www.oracle.com/java/technologies/jdk-script-friendly-urls/

dmitry-shibanov · 2022-11-16T14:58:35Z

Could you please update documentation for advanced configuration with examples for Oracle JDK ?

I'll add an example to https://github.com/actions/setup-java/blob/main/docs/advanced-usage.md

Besides, If I understood correctly, it is impossible to grab all versions from API ?

What do you mean with "grab all version from API" ?

Find a list and a description of supported versions at https://www.oracle.com/java/technologies/jdk-script-friendly-urls/

For now the logic constructs url from major or full version. Is it possible to get all available versions ?

sormuras · 2022-11-16T15:05:33Z

Ah, understood. AFAIK, it's not possible to get a list of all binaries via an API call.

There is however a listing available per "major" version at: https://www.oracle.com/java/technologies/downloads/archive/

sormuras

LGTM

dmitry-shibanov · 2022-11-23T12:28:36Z

Thank you for your description @sormuras. In this case I'm going to merge the pull request.

fniephaus · 2022-12-01T10:05:23Z

Thanks for merging this, @dmitry-shibanov. When can we expect a new release of this action so that users can use Oracle JDK and actions/setup-java@v3 as recommended?

dmitry-shibanov · 2022-12-01T13:46:56Z

Hello @fniephaus. We've released a new version of setup-java v3.7.0. Later we'll update the major tag

This reverts commit 6cdf39a.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-java](https://togithub.com/actions/setup-java) | action | minor | `v3.6.0` -> `v3.7.0` | --- ### Release Notes <details> <summary>actions/setup-java</summary> ### [`v3.7.0`](https://togithub.com/actions/setup-java/releases/tag/v3.7.0) [Compare Source](https://togithub.com/actions/setup-java/compare/v3.6.0...v3.7.0) In scope of this release we added support for Oracle JDK ([https://github.com/actions/setup-java/pull/401](https://togithub.com/actions/setup-java/pull/401)). Besides, we added logic to Pass the token input through on GHES for Microsoft Build of OpenJDK ([https://github.com/actions/setup-java/pull/395](https://togithub.com/actions/setup-java/pull/395)) and updated [minimatch](https://togithub.com/actions/setup-java/pull/413) dependency. ```yaml steps: - name: Checkout uses: actions/checkout@v3 - name: Setup-java uses: actions/setup-java@v3 with: distribution: oracle java-version: 17 ``` ##### Supported distributions Currently, the following distributions are supported: | Keyword | Distribution | Official site | License |-|-|-|-| | `temurin` | Eclipse Temurin | [Link](https://adoptium.net/) | [Link](https://adoptium.net/about.html) | `zulu` | Azul Zulu OpenJDK | [Link](https://www.azul.com/downloads/zulu-community/?package=jdk) | [Link](https://www.azul.com/products/zulu-and-zulu-enterprise/zulu-terms-of-use/) | | `adopt` or `adopt-hotspot` | AdoptOpenJDK Hotspot | [Link](https://adoptopenjdk.net/) | [Link](https://adoptopenjdk.net/about.html) | | `adopt-openj9` | AdoptOpenJDK OpenJ9 | [Link](https://adoptopenjdk.net/) | [Link](https://adoptopenjdk.net/about.html) | | `liberica` | Liberica JDK | [Link](https://bell-sw.com/) | [Link](https://bell-sw.com/liberica_eula/) | | `microsoft` | Microsoft Build of OpenJDK | [Link](https://www.microsoft.com/openjdk) | [Link](https://docs.microsoft.com/java/openjdk/faq) | `corretto` | Amazon Corretto Build of OpenJDK | [Link](https://aws.amazon.com/corretto/) | [Link](https://aws.amazon.com/corretto/faqs/) | `oracle` | Oracle JDK | [Link](https://www.oracle.com/java/technologies/downloads/) | [Link](https://java.com/freeuselicense) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Yash-Garg/qBittorrent-Manager).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

finaroux · 2022-12-01T18:31:27Z

Hey I thing this tag was a mistake I have nothing to do with this issue (wrong person). Can you fix it please? Thanks!

This reverts commit 6cdf39a. Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>

* Fix typo in README.md (actions#419) `diractory` -> `directory` * Revert "Add support for Oracle JDK (actions#401)" (actions#421) This reverts commit 6cdf39a. Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com> * adding check for prerelease * add debug lines * add minor fix * expand e2e tests with corretto Co-authored-by: Ashley <73482956+ascopes@users.noreply.github.com> Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>

This reverts commit c3ac5dd.

This reverts commit 6cdf39a. Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>

…" (actions#450) This reverts commit c3ac5dd.

fniephaus added 2 commits November 4, 2022 15:05

Add support for Oracle JDK (fixes actions#69)

2d3ab10

Test support for Oracle JDK

5c6f90e

fniephaus requested a review from a team November 4, 2022 15:07

fniephaus mentioned this pull request Nov 4, 2022

Add support for Oracle OpenJDK binaries #69

Closed

Fix formatting of oracle/installer.ts

46d7903

brunoborges approved these changes Nov 15, 2022

View reviewed changes

Make tests work on macOS and Windows

43a44e9

fniephaus force-pushed the oracle-jdk branch from 2910f33 to 43a44e9 Compare November 15, 2022 08:29

dmitry-shibanov reviewed Nov 16, 2022

View reviewed changes

Add Oracle section to advanced usage example

c0873ab

sormuras approved these changes Nov 17, 2022

View reviewed changes

panticmilos approved these changes Nov 18, 2022

View reviewed changes

dmitry-shibanov merged commit 6cdf39a into actions:main Nov 23, 2022

fniephaus deleted the oracle-jdk branch December 1, 2022 10:03

brcrista added a commit that referenced this pull request Dec 1, 2022

Revert "Add support for Oracle JDK (#401)"

ee32232

This reverts commit 6cdf39a.

dmitry-shibanov mentioned this pull request Dec 5, 2022

Revert "Add support for Oracle JDK" #421

Merged

dmitry-shibanov added a commit that referenced this pull request Dec 5, 2022

Revert "Add support for Oracle JDK (#401)" (#421)

c3ac5dd

This reverts commit 6cdf39a. Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>

dmitry-shibanov added a commit that referenced this pull request Feb 7, 2023

Revert "Revert "Add support for Oracle JDK (#401)" (#421)"

2f42f7c

This reverts commit c3ac5dd.

dmitry-shibanov added a commit that referenced this pull request Feb 7, 2023

Revert "Revert "Add support for Oracle JDK (#401)" (#421)" (#450)

3f07048

This reverts commit c3ac5dd.

yeikel pushed a commit to yeikel/setup-java that referenced this pull request Feb 12, 2023

Add support for Oracle JDK (actions#401)

195825e

yeikel pushed a commit to yeikel/setup-java that referenced this pull request Feb 12, 2023

Revert "Add support for Oracle JDK (actions#401)" (actions#421)

24a5c96

This reverts commit 6cdf39a. Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>

yeikel pushed a commit to yeikel/setup-java that referenced this pull request Feb 12, 2023

Revert "Revert "Add support for Oracle JDK (actions#401)" (actions#421)…

d185429

…" (actions#450) This reverts commit c3ac5dd.

fniephaus pushed a commit to graalvm/setup-java that referenced this pull request Jun 20, 2023

Revert "Revert "Add support for Oracle JDK (actions#401)" (actions#421)…

e865fb9

…" (actions#450) This reverts commit c3ac5dd.

fniephaus mentioned this pull request Jun 20, 2023

Add support for Oracle GraalVM #501

Merged

2 tasks

fniephaus mentioned this pull request May 7, 2024

feat: add support for SapMachine JDK/JRE #614

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Oracle JDK #401

Add support for Oracle JDK #401

fniephaus commented Nov 4, 2022

brunoborges left a comment

fniephaus commented Nov 15, 2022

dmitry-shibanov Nov 16, 2022

sormuras Nov 16, 2022

fniephaus Nov 16, 2022

dmitry-shibanov Nov 16, 2022

sormuras Nov 16, 2022

sormuras Nov 16, 2022

dmitry-shibanov commented Nov 16, 2022

sormuras commented Nov 16, 2022

dmitry-shibanov commented Nov 16, 2022

sormuras commented Nov 16, 2022 •

edited

Loading

sormuras left a comment

dmitry-shibanov commented Nov 23, 2022

fniephaus commented Dec 1, 2022

dmitry-shibanov commented Dec 1, 2022 •

edited

Loading

finaroux commented Dec 1, 2022 •

edited

Loading

Add support for Oracle JDK #401

Add support for Oracle JDK #401

Conversation

fniephaus commented Nov 4, 2022

brunoborges left a comment

Choose a reason for hiding this comment

fniephaus commented Nov 15, 2022

dmitry-shibanov Nov 16, 2022

Choose a reason for hiding this comment

sormuras Nov 16, 2022

Choose a reason for hiding this comment

fniephaus Nov 16, 2022

Choose a reason for hiding this comment

dmitry-shibanov Nov 16, 2022

Choose a reason for hiding this comment

sormuras Nov 16, 2022

Choose a reason for hiding this comment

sormuras Nov 16, 2022

Choose a reason for hiding this comment

dmitry-shibanov commented Nov 16, 2022

sormuras commented Nov 16, 2022

dmitry-shibanov commented Nov 16, 2022

sormuras commented Nov 16, 2022 • edited Loading

sormuras left a comment

Choose a reason for hiding this comment

dmitry-shibanov commented Nov 23, 2022

fniephaus commented Dec 1, 2022

dmitry-shibanov commented Dec 1, 2022 • edited Loading

finaroux commented Dec 1, 2022 • edited Loading

sormuras commented Nov 16, 2022 •

edited

Loading

dmitry-shibanov commented Dec 1, 2022 •

edited

Loading

finaroux commented Dec 1, 2022 •

edited

Loading