Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating nextjs.yml for Next.js 14 Support #2204

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Conversation

NPJigaK
Copy link
Contributor

@NPJigaK NPJigaK commented Oct 27, 2023

PR Description

Overview

https://nextjs.org/blog/next-14#other-changes

[Breaking] next export command is deprecated in favor of output: 'export' (Docs)

This pull request tackles a major alteration incorporated in Next.js 14— the deprecation of the next export command, now supplanted by output: 'export' as delineated in the Next.js documentation. By amending our codebase in alignment with this new provision, we're ensuring seamless compatibility moving forward.

Background

The advent of Next.js 14 has ushered in a paradigm shift towards a more coherent and intuitive configuration ethos. A testament to this is the modification in the export functionality configuration, transitioning from next export to output: 'export', showcasing the framework's evolutionary trajectory.

We're thankful for your meticulous review and comprehension.

@NPJigaK NPJigaK requested review from a team as code owners October 27, 2023 02:45
@071yoon
Copy link

071yoon commented Nov 20, 2023

hi, i had similar problem with publishing Next.14 and led me to here.

since Next.14 officially uses node version to 18.17 as minimum(Next.14 update), i thought maybe it would be great to update node version to 18 at yml here

@JamesMGreene JamesMGreene added the pages Related to workflows that show on the GitHub Pages settings page label Jan 12, 2024
@alexisabril alexisabril merged commit 61cdce2 into actions:main Mar 25, 2024
3 checks passed
@alexisabril
Copy link
Contributor

Thank you @NPJigaK for the PR!

@JamesMGreene
Copy link
Contributor

JamesMGreene commented Mar 30, 2024

ℹ️ FWIW, this change alone wasn't really a proper fix as actions/configure-pages@v4 wasn't compatible with Next.js >= 14. 😕

This should be resolved now if you create a new Next.js starter workflow using our updated template as it included a newly minted actions/configure-pages@v5 that offers better static site generator configuration support for Next.js >= 13.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pages Related to workflows that show on the GitHub Pages settings page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants