Add MultiSafepay icon #1237
Open
Add MultiSafepay icon #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to receive feedback for this PR and, ideally, an estimated time of when we could hope to have these payment method icons added or updated? |
Lydia-shan-git
requested changes
Nov 4, 2024
|
Hi @Lydia-shan-git. Thanks for your review. We already passed the icon through SVGO following your guidelines: https://github.com/activemerchant/payment_icons/blob/master/CONTRIBUTING.md As you can see, with that ruleset, there is no change in the size of the file. |
Lydia-shan-git
approved these changes
Nov 5, 2024
|
Thank you for checking and approving this pull request. We are concerned that even after approval, this pull request is still tagged as " Changes Requested", and that due to this it may go unnoticed in the next release, thus delaying taking advantage of these changes.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you adding this icons?
MultiSafepay payment icon is missing. MultiSafepay has pioneered Europe's most personalized payments ecosystem for small to medium-sized businesses and marketplaces. More than 18,000 businesses have simplified their market expansion and freed up time to focus on innovation with MultiSafepay's end-to-end payments toolkit.
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.ymlIf this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?