Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neocuotas icon, request from Tilopay #1254

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

norud
Copy link

@norud norud commented Nov 15, 2024

Why are you adding this icons?

I'm adding/updating this icon(s) because is not at the list

Help us identify yourself

  • I'm working/collaborating with the brand directly and they have provided the icons.
  • I'm associated with the brand and I've read all the brand icon’s guidelines.
  • I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines:

Checklist to add new icons

  • All icons have a corresponding entry in db/payment_icons.yml
  • I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • I have optimized the icon with SVGO
  • I am confident that all icons are clear and easy to read/understand
  • I have provided a link to the brand icon’s brand guidelines whenever possible.
  • I have attached a screenshot comparison with the example icon provided in guidelines
  • I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

image

Tips how to create a screenshot

We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.

<!-- Change background color if needed to showcase your icon better -->
<style> body { background: black; } </style>

<!-- DO NOT DELETE EXAMPLE -->
<svg viewBox="0 0 38 24" xmlns="http://www.w3.org/2000/svg" role="img" width="38" height="24" aria-labelledby="pi-visa"><title id="pi-visa">Visa</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path d="M28.3 10.1H28c-.4 1-.7 1.5-1 3h1.9c-.3-1.5-.3-2.2-.6-3zm2.9 5.9h-1.7c-.1 0-.1 0-.2-.1l-.2-.9-.1-.2h-2.4c-.1 0-.2 0-.2.2l-.3.9c0 .1-.1.1-.1.1h-2.1l.2-.5L27 8.7c0-.5.3-.7.8-.7h1.5c.1 0 .2 0 .2.2l1.4 6.5c.1.4.2.7.2 1.1.1.1.1.1.1.2zm-13.4-.3l.4-1.8c.1 0 .2.1.2.1.7.3 1.4.5 2.1.4.2 0 .5-.1.7-.2.5-.2.5-.7.1-1.1-.2-.2-.5-.3-.8-.5-.4-.2-.8-.4-1.1-.7-1.2-1-.8-2.4-.1-3.1.6-.4.9-.8 1.7-.8 1.2 0 2.5 0 3.1.2h.1c-.1.6-.2 1.1-.4 1.7-.5-.2-1-.4-1.5-.4-.3 0-.6 0-.9.1-.2 0-.3.1-.4.2-.2.2-.2.5 0 .7l.5.4c.4.2.8.4 1.1.6.5.3 1 .8 1.1 1.4.2.9-.1 1.7-.9 2.3-.5.4-.7.6-1.4.6-1.4 0-2.5.1-3.4-.2-.1.2-.1.2-.2.1zm-3.5.3c.1-.7.1-.7.2-1 .5-2.2 1-4.5 1.4-6.7.1-.2.1-.3.3-.3H18c-.2 1.2-.4 2.1-.7 3.2-.3 1.5-.6 3-1 4.5 0 .2-.1.2-.3.2M5 8.2c0-.1.2-.2.3-.2h3.4c.5 0 .9.3 1 .8l.9 4.4c0 .1 0 .1.1.2 0-.1.1-.1.1-.1l2.1-5.1c-.1-.1 0-.2.1-.2h2.1c0 .1 0 .1-.1.2l-3.1 7.3c-.1.2-.1.3-.2.4-.1.1-.3 0-.5 0H9.7c-.1 0-.2 0-.2-.2L7.9 9.5c-.2-.2-.5-.5-.9-.6-.6-.3-1.7-.5-1.9-.5L5 8.2z" fill="#142688"/></svg>

<!-- TODO: insert your icon here -->
<svg xmlns="http://www.w3.org/2000/svg" width="38" height="24" aria-labelledby="pi-neocuotas" viewBox="0 0 38 24"><title id="pi-neocuotas">Neocuotas</title><g fill="none" fill-rule="nonzero" viewBox="0 0 38 24"><rect width="38" height="24" fill="#FFF" stroke="#000" stroke-opacity=".07" rx="2"/><path fill="#5F249F" d="M16.32 8.06c.2-.68.9-1.08 1.59-.9.71.18 1.06.69 1.28 1.39l1.18 3.17 2.84-6.11C21.85 4.7 20.3 4 18.54 4c-4.72 0-8.55 3.85-8.55 8.6 0 2.7 1.23 5.1 3.17 6.68l3.15-11.22h.01Z"/><path fill="#5F249F" d="M21.68 16.12c-.2.68-.9 1.08-1.59.9-.71-.18-1.06-.69-1.28-1.39l-1.18-3.17-2.84 6.11c1.36.91 2.91 1.61 4.67 1.61 4.72 0 8.55-3.85 8.55-8.6 0-2.7-1.23-5.1-3.17-6.68l-3.15 11.22h-.01Z"/></g></svg>

</br

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
Tilopay

What's the expected date of this change to deploy on Shopify?
Monday, November 18, 2024

Copy link
Collaborator

@Lydia-shan-git Lydia-shan-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

border colour should be #000 and 7% opacity and 1px thick in width with a 2px radius. All laid out in our guidelines

@norud
Copy link
Author

norud commented Nov 28, 2024

@Lydia-shan-git @dannye0231 PR updated

@dannye0231
Copy link
Contributor

Hi @norud , are you able to look into the errors that were flagged with the SVG formatting/tags?

PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:68]:
{:message=>"The 'neocuotas' SVG file should have a single <title> tag"}.
Expected: 1
Actual: 0

rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:61

.F

Failure:
PaymentIconTest#test_Every_payment_icon_SVG_has_a_viewBox_attribute [test/unit/payment_icon_test.rb:56]:
{:message=>"The 'neocuotas' SVG file should have a 'viewBox' attribute on the root tag"}

rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:53

.

-The 'neocuotas' SVG file should have a single
-The 'neocuotas' SVG file should have a 'viewBox' attribute on the root tag
@norud
Copy link
Author

norud commented Nov 28, 2024

@dannye0231 Thanks, I've already applied the feedback, can you try again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants