-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neocuotas icon, request from Tilopay #1254
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border colour should be #000 and 7% opacity and 1px thick in width with a 2px radius. All laid out in our guidelines
@Lydia-shan-git @dannye0231 PR updated |
Hi @norud , are you able to look into the errors that were flagged with the SVG formatting/tags? PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:68]: rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:61 .F Failure: rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:53 . |
@dannye0231 Thanks, I've already applied the feedback, can you try again? |
Why are you adding this icons?
I'm adding/updating this icon(s) because is not at the list
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
Tilopay
What's the expected date of this change to deploy on Shopify?
Monday, November 18, 2024