Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc 74533/trustedform v4 verify language approved is #118

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

GreenAsGrassAP
Copy link
Contributor

Description of the change

Removed language from response variables per Leandro's suggestion on the shortcut ticket

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change
  • Technical Debt
  • Documentation

Related tickets

https://app.shortcut.com/active-prospect/story/74533/trustedform-v4-verify-language-approved-is-not-being-appended

Checklists

Development and Testing

  • Lint rules pass locally.
  • The code changed/added as part of this pull request has been covered with tests, or this PR does not alter production code.
  • All tests related to the changed code pass in development, or tests are not applicable.

Code Review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • At least two engineers have been added as "Reviewers" on the pull request.
  • Changes have been reviewed by at least two other engineers who did not write the code.
  • This branch has been rebased off master to be current.

Tracking

  • Issue from Shortcut/Jira has a link to this pull request.
  • This PR has a link to the issue in Shortcut.

QA

  • This branch has been deployed to staging and tested.

josevsalina
josevsalina previously approved these changes Jul 29, 2024
@GreenAsGrassAP GreenAsGrassAP dismissed josevsalina’s stale review July 30, 2024 17:03

The merge-base changed after approval.

Copy link
Contributor

@jgrayson676 jgrayson676 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there supposed to be more changes here beyond adding a period to a changelog line?

@GreenAsGrassAP
Copy link
Contributor Author

I believe it may not be picking up changes as I switched the names on lines 258-260 on file "trustedform.js" back to include "verify." to keep with Leandro's comments.

Copy link
Contributor

@jgrayson676 jgrayson676 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks fine, but you'll need to update the failing tests accordingly

@jgrayson676
Copy link
Contributor

Hmm, after this most recent change the PR is back to only adding a period to a changelog entry. What's this PR meant to be changing? It isn't super clear to me from the description.

Copy link

@josevsalina josevsalina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the only change that you want to merge?

@GreenAsGrassAP
Copy link
Contributor Author

@josevsalina this should not be necessary. I will update the LC API.

@josevsalina josevsalina marked this pull request as draft September 23, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants