-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sc 74533/trustedform v4 verify language approved is #118
base: master
Are you sure you want to change the base?
Sc 74533/trustedform v4 verify language approved is #118
Conversation
…e it is a boolean value
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there supposed to be more changes here beyond adding a period to a changelog line?
I believe it may not be picking up changes as I switched the names on lines 258-260 on file "trustedform.js" back to include "verify." to keep with Leandro's comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks fine, but you'll need to update the failing tests accordingly
Hmm, after this most recent change the PR is back to only adding a period to a changelog entry. What's this PR meant to be changing? It isn't super clear to me from the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the only change that you want to merge?
@josevsalina this should not be necessary. I will update the LC API. |
Description of the change
Removed language from response variables per Leandro's suggestion on the shortcut ticket
Type of change
Related tickets
https://app.shortcut.com/active-prospect/story/74533/trustedform-v4-verify-language-approved-is-not-being-appended
Checklists
Development and Testing
Code Review
Tracking
QA