Skip to content

Conversation

@robjtede
Copy link
Member

@robjtede robjtede commented Feb 22, 2022

PR Type

Release

PR Checklist

  • A changelog entry has been made for the appropriate packages.
  • (Team) Label with affected crates and semver status.

Overview

It's quite possible that actix-router will get folded into actix-web itself soon but worth making a stable release of 0.5.0 anyway.

Thoughts on the changelog pre-release rollup? Was thinking about doing this for other crates too. (See the rich diff / view file to see effect.)

@robjtede robjtede added B-semver-major breaking change requiring a major version bump A-router project: router labels Feb 22, 2022
@robjtede robjtede requested review from a team and aliemjay February 22, 2022 00:55
Copy link
Member

@aliemjay aliemjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on the changelog pre-release rollup?

Just great 👍 . It would be nice if it also merges multiple iterations on the same api in a single entry,
like renaming capture_match_info and changing its signature. I can see it'd be a daunting task for actix-web though.

iirc clippy was complaining about adding must_use to ResourceDef::join. Might be a good idea to add it now.

@robjtede
Copy link
Member Author

robjtede commented Feb 22, 2022

would be nice if it also merges multiple iterations on the same api in a single entry

Agree, think i spotted a couple of them here but will try a bit harder for AW; i can think of some obvious ones that should not be included.

adding must_use to ResourceDef::join

Not sure what case you mean, and it would be non-breaking right?

@aliemjay
Copy link
Member

Not sure what case you mean, and it would be non-breaking right?

Nevermind. I remembered having a clippy lint against ResourceDef::join not using must_use but It is clear now. maybe a clippy update!

@robjtede robjtede merged commit 75e6ffb into master Feb 22, 2022
@robjtede robjtede deleted the router050 branch February 22, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-router project: router B-semver-major breaking change requiring a major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants