test: Check if we end up in the expected volume in Gen1 Navigator

[andiwand]

I think this is one of the big navigation pitfalls. If we end up in the wrong volume the navigation is practically lost. This is too expensive to check in production so I opted for an assert.

Not sure if that is a great solution since users might try to measure performance with non release build by accident. But that was the only way I could think of.

blocked by

• fix: Change the component reducer for the GSF (to fix navigation issues) #3521
• fix: Return nullptr if outside tracking geometry in TrackingGeometry::lowestTrackingVolume #3481

[github-actions]

📊: Physics performance monitoring for f1e66d1

Full contents

physmon summary

• ✅ Particles fatras
• ✅ Particles geant4
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (KF)
• ✅ Truth tracking (GSF)
• ✅ Truth tracking (GX2F)
• ✅ CKF | trackfinding | single muon | truth smeared seeding
• ✅ Track Summary CKF | trackfinding | single muon | truth smeared seeding
• ✅ Seeding trackfinding | single muon | truth estimated seeding
• ✅ CKF | trackfinding | single muon | truth estimated seeding
• ✅ Track Summary CKF | trackfinding | single muon | truth estimated seeding
• ✅ Seeding trackfinding | single muon | default seeding
• ✅ CKF | trackfinding | single muon | default seeding
• ✅ Track Summary CKF | trackfinding | single muon | default seeding
• ✅ Seeding trackfinding | single muon | orthogonal seeding
• ✅ CKF | trackfinding | single muon | orthogonal seeding
• ✅ Track Summary CKF | trackfinding | single muon | orthogonal seeding
• ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Track Summary CKF | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Ambisolver | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Track Summary CKF | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Ambisolver | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding

[paulgessinger]

I really like the idea to have this (conditionally) be a hard failure.

One alternative to the assert would be an explicit configuration that sets up a hardened navigation mode where this check is performed.

On another note: we force-enable assert even on non-Debug builds in the CI so that we gain exposure to assertion failures. So, depending on the slowdown, this might be an issue.

[andiwand]

Problem with the GSF and GX2F can be observed here @benjaminhuth @AJPfleger

[andiwand]

I really like the idea to have this (conditionally) be a hard failure.

One alternative to the assert would be an explicit configuration that sets up a hardened navigation mode where this check is performed.

On another note: we force-enable assert even on non-Debug builds in the CI so that we gain exposure to assertion failures. So, depending on the slowdown, this might be an issue.

I did not really think of the CI. We have to see how bad it is. But I would trade some performance for this because otherwise we might just not end up checking this at all

[andiwand]

physmon ttbar changes because we now cut on different particles

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
56.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[AJPfleger]

Problem with the GSF and GX2F can be observed here @benjaminhuth @AJPfleger

I might have fixed the gx2f issue with

• fix(gx2f): constrain update to initial volume #3411

ready to update? :)

[andiwand]

@AJPfleger it is now failing inside the unit test

13:43:23    Navigator      VERBOSE   No Volume | Initialization.
13:43:23    Navigator      VERBOSE   No Volume | Slow start initialization through search.
13:43:23    Navigator      VERBOSE   No Volume | Starting from position (750.0221, -749.9779, -0.1743) and direction (-0.2816, 0.9595, 0.0001)
13:43:23    Navigator      VERBOSE   TestVolume | Start volume resolved.
ActsUnitTestGx2f: /__w/acts/acts/Core/include/Acts/Propagator/Navigator.hpp:325: void Acts::Navigator::initialize(propagator_state_t&, const stepper_t&) const [with propagator_state_t = Acts::PropagatorState<Acts::PropagatorOptions<Acts::EigenStepper<>::Options, Options, Acts::ActionList<Acts::Experimental::Gx2Fitter<const Acts::Propagator<Acts::EigenStepper<>, Acts::Navigator>, Acts::VectorMultiTrajectory>::Actor<Acts::GenericBoundTrackParameters<Acts::ParticleHypothesis> > >, Acts::AbortList<Acts::Experimental::Gx2Fitter<const Acts::Propagator<Acts::EigenStepper<>, Acts::Navigator>, Acts::VectorMultiTrajectory>::Aborter<Acts::GenericBoundTrackParameters<Acts::ParticleHypothesis> >, Acts::PathLimitReached> >, Acts::EigenStepper<>::State, State, Acts::Experimental::Gx2FitterResult<Acts::VectorMultiTrajectory> >; stepper_t = Acts::EigenStepper<>]: Assertion `state.navigation.startVolume->inside( stepper.position(state.stepping), state.options.surfaceTolerance) && "We did not end up inside the volume."' failed.
unknown location(0): fatal error: in "Gx2fTest/UpdatePushedToNewVolume": signal: SIGABRT (application abort requested)

[andiwand]

This is not blocked by #3481. lowestTrackingVolume determines a volume for a position we are not in which then causes the assert to fire.

[AJPfleger]

Looks good in general :)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
54.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[acts-project-service]

🔴 Athena integration test results [b656c03]

🔴 Some tests have failed!

Please investigate the pipeline!

status	job	report
🟢	report_pull_request
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco
🟢	test_ActsDumpGeometryIdentifiers
🔴	test_ActsCheckObjectCountsCachedWorkflow
🔴	test_ActsCheckObjectCountsWorkflow
🟢	test_ActsEFTrackFit
🟢	test_ActsPersistifySeeds
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsAnalogueClustering
🟢	test_ActsWorkflowHeavyIons
🟢	test_ActsWorkflowFastTracking
🟢	test_ActsWorkflowCached
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_unit_tests