Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow resetting reference surface in Track EDM #3586

Merged
merged 2 commits into from
Sep 4, 2024
Merged

fix: Allow resetting reference surface in Track EDM #3586

merged 2 commits into from
Sep 4, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Sep 2, 2024 •
edited
Loading

Currently copyFrom will not reset the reference surface in case other does not have one. This is fixed here and another bug in the podio backend was discovered which disallowed resetting the reference surface all together.

discovered in #3534

@andiwand andiwand added this to the next milestone Sep 2, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Event Data Model labels Sep 2, 2024
@andiwand andiwand mentioned this pull request Sep 2, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024 •
edited
Loading

📊: Physics performance monitoring for fc5225e

Full contents

physmon summary

@andiwand andiwand marked this pull request as ready for review September 2, 2024 17:31
@acts-project-service
Copy link
Collaborator

acts-project-service commented Sep 2, 2024 •
edited
Loading

✅ Athena integration test results [56b8fb4]

✅ All tests successful

status job report
🟢 report_pull_request
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco
🟢 test_ActsDumpGeometryIdentifiers
🟢 test_ActsCheckObjectCountsCachedWorkflow
🟢 test_ActsCheckObjectCountsWorkflow
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflowCached
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_unit_tests

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Sep 2, 2024
@andiwand andiwand added automerge and removed Fails Athena tests This PR causes a failure in the Athena tests labels Sep 3, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit 56b8fb4 into acts-project:main Sep 4, 2024
42 checks passed
@github-actions github-actions bot removed the automerge label Sep 4, 2024
@andiwand andiwand deleted the fix-trackedm-reset-refsurface branch September 4, 2024 03:47
kodiakhq bot pushed a commit that referenced this pull request Sep 6, 2024
@andiwand
feat: Allow user to supply root branch to Core CKF (#3534)
26b059f 
Adding an overload to the Core CKF which allows the user to supply a root branch. This is useful if the finding has multiple stages, i.e. forward and backward, and the tip state quantities like `nMeasurements` and `nHoles` should persist so the branch stopper can observe them.

blocked by
- #3586
- #3587
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timadye timadye timadye approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Event Data Model
Projects
None yet
Milestone
v37.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@andiwand @acts-project-service @timadye @paulgessinger