Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use std::ranges::all_of, any_of, none_of #3593

Merged
merged 20 commits into from
Oct 3, 2024

Conversation

AJPfleger
Copy link
Contributor

I couldn't replace all instances, since https://github.com/acts-project/acts/blame/464675980c50a6070f5635127ee27fd29de5a679/Core/include/Acts/Propagator/MultiEigenStepperLoop.hpp#L458 seems not to return an iterator, that can be interpreted by ranges algorithms.

@AJPfleger AJPfleger added this to the next milestone Sep 4, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Track Finding labels Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

📊: Physics performance monitoring for dd52b69

Full contents

physmon summary

@AJPfleger AJPfleger marked this pull request as ready for review September 4, 2024 22:04
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all of these are in <algorithm> and not actually in <ranges>, so you might want to adjust the includes.

This reverts commit 80b44d4.
stephenswat
stephenswat previously approved these changes Sep 10, 2024
Plugins/ExaTrkX/src/ExaTrkXPipeline.cpp Outdated Show resolved Hide resolved
Plugins/ExaTrkX/src/ExaTrkXPipeline.cpp Outdated Show resolved Hide resolved
@stephenswat
Copy link
Member

LGTM, just a small, non-critical suggestion.

stephenswat
stephenswat previously approved these changes Sep 10, 2024
@acts-policybot acts-policybot bot dismissed stephenswat’s stale review October 2, 2024 13:53

Invalidated by push of bad2f91

Copy link

sonarcloud bot commented Oct 3, 2024

@kodiakhq kodiakhq bot merged commit dfc2aff into acts-project:main Oct 3, 2024
42 checks passed
@github-actions github-actions bot removed the automerge label Oct 3, 2024
@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Oct 3, 2024
@AJPfleger AJPfleger deleted the ranges-of branch October 3, 2024 21:13
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 4, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Fails Athena tests This PR causes a failure in the Athena tests Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants