Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace Acts::min_max with std::ranges::minmax_element #3601

Merged
merged 4 commits into from
Sep 10, 2024
Merged

refactor: replace Acts::min_max with std::ranges::minmax_element #3601

merged 4 commits into from
Sep 10, 2024

Conversation

AJPfleger
Copy link
Contributor

No description provided.

@AJPfleger AJPfleger added this to the next milestone Sep 6, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label Sep 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

📊: Physics performance monitoring for f96f491

Full contents

physmon summary

@AJPfleger AJPfleger marked this pull request as ready for review September 7, 2024 01:16
stephenswat
stephenswat previously approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Core/include/Acts/Utilities/Helpers.hpp Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit eebeb36 into acts-project:main Sep 10, 2024
44 checks passed
@AJPfleger AJPfleger deleted the minmax branch September 10, 2024 11:54
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [eebeb36]

🔴 Some tests have failed!

Please investigate the pipeline!

status job report
🟢 report_pull_request
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco
🟢 test_ActsDumpGeometryIdentifiers
🔴 test_ActsCheckObjectCountsCachedWorkflow
🔴 test_ActsCheckObjectCountsWorkflow
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🔴 test_ActsBenchmarkWithSpot
🔴 test_ActsAnalogueClustering
🔴 test_ActsWorkflowHeavyIons
🔴 test_ActsWorkflowFastTracking
🔴 test_ActsWorkflowCached
🔴 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🔴 test_ActsValidateResolvedTracks
🔴 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🔴 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_unit_tests

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Sep 10, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenswat stephenswat stephenswat approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Milestone
v37.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AJPfleger @acts-project-service @stephenswat @paulgessinger